SparklyPower / SparklyPaper

✨ "Ooooh, sparkly paper!" - SparklyPower's Paper fork, making large servers snappier with high-performance optimizations and improvements!
https://sparklypower.net/
121 stars 13 forks source link

Fix Nether and End portals for non-player entities #11

Closed alexthvest closed 5 months ago

alexthvest commented 9 months ago

I tried to fix problems with non-player entities and portals cause some will need this functionallity on their server (like we're).

The main problem I found that teleportation ticked on ServerLevel tick thread but entities neeed to check Poi in another world. I use taskScheduler to schedule changeDimension on main thread.

MrPowerGamerBR commented 9 months ago

Instead of creating a new patch, it would be better to amend the 0018-Parallel-world-ticking.patch patch.

It would also be nice to see how Folia handles entity teleport between worlds, iirc Folia completly changes how portal teleports work but yeah, another fix is to just schedule entity moves to be handled after the worlds are ticked.

Potothingi commented 6 months ago

Hello. When will this be resolved?

DaddyRobLIVE commented 5 months ago

Any update here? I think this is an important vanilla feature.

Potothingi commented 2 months ago

I can't apply this change in 1.21.1. The portal code has changed a lot. What should I do?

Potothingi commented 2 months ago

https://github.com/SparklyPower/SparklyPaper/pull/34