SparkyBluefang / S4E

Status-4-Evar Firefox Extension
Mozilla Public License 2.0
60 stars 18 forks source link

Waterfox update breaks S4E #55

Closed rebop closed 3 years ago

rebop commented 4 years ago

Hi folks, Waterfox updated yesterday to Classic 2019-10. Previously S4E worked flawlessly. Now, the only glitch I see is that the progress bar is green regardless how S4E is set. About:config and prefs.js both show the settings I have made perfectly. Its as if S4E no longer reads those settings.

Is there a fix?

Thanks so much.

dodona2 commented 4 years ago

hovering over any link always displays "Status Text" at the left corner in the status bar. Otherwise it works with my Classic 2019-10. Any clue?

rebop commented 4 years ago

Hovering works for me. All that "seems" not to is the custom color of the progress bar. As mentioned, about:config looks proper: about

hawkeye116477 commented 4 years ago

On console I saw error this.watch is not a function", so maybe that's because object.prototype.watch was removed, because it caused problems with some websites like mlb.com. Replacement for Object.prototype.watch exists (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy).

dodona2 commented 4 years ago

hovering works with linux/fedora 30. The above mentioned problem only occurs under windows 10.

rebop commented 4 years ago

i have no issues with hovering in Windows 10. But the progress bar issue in BOTH Windows 7 ad Windows 10.

grahamperrin commented 4 years ago

@JustOff ▲ and https://github.com/MrAlex94/Waterfox/issues/1238#issuecomment-547204716

613TheEvil commented 4 years ago

It no longer works, sadly. Can a fix be found? I hate the hovering links!

9jkh commented 4 years ago

S4E with 2019.10 now shows anemic, very thin progress bar. Please see OP at https://www.reddit.com/r/waterfox/comments/docu2c/201910_status4evar_addon_progress_bar_much/

The update appears to have adversely affected other extensions besides this one. Awaiting a fix as soon as possible.

rebop commented 4 years ago

Does not look like the browsers are going to change, though I hope they reconsider. Any chance to get Staus 4 Evar updated to work around this?

grahamperrin commented 4 years ago

Does not look like the browsers are going to change,

https://github.com/MoonchildProductions/UXP/commit/ff881bdb6795e0f307b93919f98f454bedde4bb6

Any chance to get Staus 4 Evar updated to work around this?

FYI maybe worth subscribing to https://github.com/JustOff/L4E/issues/1 although please note that (fork of Status-4-Evar) Location-4-Evar is for Pale Moon; not compatible with Waterfox Classic.

SparkyBluefang commented 4 years ago

S4E only officially supported Firefox, and I don't use any of the forks. So when Firefox dropped support for XUL extensions, S4E became unsupported.

You're welcome to create a fork and continue developing. Though I do request that you change the extension ID and namespace if you plan on publishing a new version.

i.e.

# Replace all "caligonstudios.com" with "developer.com"
find . -type f -not -path "./.git/*" -not -name ChangeLog -exec sed -i 's/caligonstudios.com/developer.com/g' '{}' \;

# Replace all "caligon" with "namespace"
find . -type f -not -path "./.git/*" -not -name ChangeLog -exec sed -i 's/caligon/namespace/g' '{}' \;
rebop commented 4 years ago

S4E only officially supported Firefox, and I don't use any of the forks. So when Firefox dropped support for XUL extensions, S4E became unsupported.

You're welcome to create a fork and continue developing. Though I do request that you change the extension ID and namespace if you plan on publishing a new version.

If directed at me, I am not a programmer. And Waterfox "Classic" does support XUL. In my opinion its the reason for its being! So the WF removal of those classes broke S4E. So either WF needs to add them back and "seems" to be saying no as they were removed because they broke "some" websites, or S4E as it is pre removal of XUL needs a tweak. I'd love to see one or the other.

hawkeye116477 commented 4 years ago

If author doesn't want to rewrite few things, then simpler fix could by done by just adding polyfill to extension (https://github.com/MoonchildProductions/UXP/commit/ff881bdb6795e0f307b93919f98f454bedde4bb6). PS: Maybe in the future release of Waterfox, status bar will be integrated, but it might be less advanced just like on Vivaldi.

rebop commented 4 years ago

I'd be happy to try that on Waterfox if you tell me what I need to do to add that. Remember, I am just a user. Perhaps a power user, but not a programmer.

hawkeye116477 commented 4 years ago

Fixed version available on https://github.com/hawkeye116477/S4E/releases

rebop commented 4 years ago

Thank you!!!!


From: hawkeye116477 [mailto:notifications@github.com] Sent: Sunday, November 10, 2019 4:42 AM To: SparkyBluefang/S4E Cc: rebop; Author Subject: Re: [SparkyBluefang/S4E] Waterfox update breaks S4E (#55)

Fixed version available on https://github.com/hawkeye116477/S4E/releases

- You are receiving this because you authored the thread. Reply to this email directly, view https://github.com/SparkyBluefang/S4E/issues/55?email_source=notifications& email_token=ADJFPUWVNUEIFQ3YPATMWTLQS76QRA5CNFSM4JFSLHSKYY3PNVWWK3TUL52HS4DF VREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDU4JMI#issuecomment-552191153 it on GitHub, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJFPUVKR4RWBFUFIUMWNQDQS 76QRANCNFSM4JFSLHSA . https://github.com/notifications/beacon/ADJFPUVPQCLL2SCNM5HQFATQS76QRA5CNFS M4JFSLHSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDU4JMI .gif

rebop commented 4 years ago

Working as expected with the exception that I can no longer customize the status bar. It overlaps another bar so elements cannot be rearranged or changed. image

rebop commented 4 years ago

UPDATE:

With multiple tabs open, the customize has the two toolbars overlapping. With only one tab open, customize works as expected and two toolbars are visible and customizable.

hawkeye116477 commented 4 years ago

@rebop I forgot to mention that you should disable old Status-4-Evar.

rebop commented 4 years ago

I removed it when I installed the new version :)


From: hawkeye116477 [mailto:notifications@github.com] Sent: Sunday, November 10, 2019 8:36 AM To: SparkyBluefang/S4E Cc: rebop; Mention Subject: Re: [SparkyBluefang/S4E] Waterfox update breaks S4E (#55)

@rebop https://github.com/rebop I forgot to mention that you should disable old Status-4-Evar.

- You are receiving this because you were mentioned. Reply to this email directly, view https://github.com/SparkyBluefang/S4E/issues/55?email_source=notifications& email_token=ADJFPUQGA4HXEFTGJADFLOTQTA2AJA5CNFSM4JFSLHSKYY3PNVWWK3TUL52HS4DF VREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDVBEEI#issuecomment-552210961 it on GitHub, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJFPUUGOIMRU47ETVZWW2LQT A2AJANCNFSM4JFSLHSA . https://github.com/notifications/beacon/ADJFPUSFCK3OBZM5D5YJGGDQTA2AJA5CNFS M4JFSLHSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDVBEEI .gif

rebop commented 4 years ago

UPDATE: Takes more than just a few to occlude the status bar from customization by the tabs at the bottom. Two did not do it. A small session of 17 tabs did right away. Seems need to be enough to span the bottom of the browser window with tabs before the tabs occlude the status bar from customizing. Make sense?

grahamperrin commented 4 years ago

I see a minor issue but I'll not report it here. I might not report it at all :-)

(It might be desktop environment theme-related, not at the extension level.)

Big thanks!

crudebuster commented 4 years ago

Well, the fork works so I want to thank Sparky for all his work and support by these years. Maybe someday we'll have a browser that gives back all the freedom Firefox insists to scrap while giving back horse manure.

9jkh commented 4 years ago

Grateful for the work that went into this, but doesn't change the issue I'm still having, which is the very skinny, as in thin, progress bar. Everything else was working in the original version, so still using that.

crudebuster commented 4 years ago

Grateful for the work that went into this, but doesn't change the issue I'm still having, which is the very skinny, as in thin, progress bar. Everything else was working in the original version, so still using that.

Get the fork https://github.com/hawkeye116477/S4E/releases , it's fixed.