search

Sparronator9999 / YAMDCC

Yet Another MSI Dragon Center Clone - A fast, lightweight alternative to MSI Center for MSI laptops, written in C#.
GNU General Public License v3.0
19 stars 0 forks source link

YAMDCC service crash when using EC monitor for a long time #21

Open porkmanager opened 2 weeks ago

porkmanager commented 2 weeks ago

image What I done: Just started yamdcc, choose the profile, enabled ECmonitoring, turn on\off full blast and forgot to close the window after applying what I wanted. It was run in background on my desktop for a few minutes, then I found it with this error.

crash-2024-10-07T20-15-31.txt yamdccsvc.exe.log

Sparronator9999 commented 2 weeks ago

Congratulations, you've managed to crash the IPC component of YAMDCC.

Basically, the YAMDCC service stopped responding to the config app after a while, but the config app continued to pile on requests to the service (EC monitoring), until the queue reached max capacity and crashed.

I will look into this more later.

Oh, and nice issue title :)

Sparronator9999 commented 2 weeks ago

Hi, can you please update to the latest commit, then try to reproduce the above error?

I didn't fix the bug, but the output from the latest commit should help me figure out the problem (keyword: should)

porkmanager commented 2 weeks ago

Hey, sure I will try the last one. Btw I tried to reproduce this bug on the yesterday's version again and i cant repeat it one more time

Sparronator9999 commented 2 weeks ago

I'm still not exactly sure what happened either. I think the service froze or crashed, and the config app isn't set up to handle service crashes after launch (yet). This is upcoming, but I've been too busy with both work and uni to do anything more than fixing my stupid mistakes/other smaller bugs.

Sparronator9999 commented 2 weeks ago

Okay, I've managed to reproduce the bug on my end: the service seems to stop taking requests from the config app after some time, then the config app crashes after the "queue" of service requests builds up too much (I didn't let it get to that stage).

Now I have to figure out why the service freezes after a long EC monitoring session.

porkmanager commented 2 weeks ago

The latest one just hanging. I started it and go to get some coffe then I see this:

yamdccsvc.exe.log

Sparronator9999 commented 2 weeks ago

Yep, it's happening for me as well.

Closing and re-opening the config app temporarily fixes this issue for me.

Sparronator9999 commented 2 weeks ago

Worst of all, my crash logging "fixes" don't seem to be doing anything.

Sparronator9999 commented 2 weeks ago

Hi, I am going to add this issue to the list of known issues on the Issues Megathread for now.

Just... don't leave the EC monitor running for a long time for now?

I will fix this eventually, but probably not for a few weeks.