search

Sparsh1212 / gsocanalyzer

A blazingly fast tool to analyze all the selected organizations in Google Summer of Code in the form of graphical analytics.
MIT License
75 stars 39 forks source link

Select a search option using keyboard arrows #44

Open aryabagde opened 2 years ago

aryabagde commented 2 years ago

When we type something on the search box, we should be able to select the options available using keyboard arrows

aryabagde commented 2 years ago

Can I work on this issue?

Sparsh1212 commented 2 years ago

The issue looks genuine to me. Feel free to work on this.

aryabagde commented 2 years ago

Can you assign it to me and add labels on this issue?

Sparsh1212 commented 2 years ago

@aryabagde Any update on this?

iamrahulrnair commented 2 years ago

can i work on this?

iamrahulrnair commented 2 years ago

Hey, do I have to comment in the codebase ? what's the procedure? I've spend some time figuring out the type of states without documentation, and also please check is this the intended behaviour?

https://user-images.githubusercontent.com/55950758/145517092-d44693c5-0e09-4dd1-a294-4d0b8537e4a6.mp4

.

iamrahulrnair commented 2 years ago

guys ,can i get a review on this?

Sparsh1212 commented 2 years ago

guys ,can i get a review on this?

Looks good to me. You can submit a PR for this.

aritroCoder commented 2 years ago

I have fixed this issue. Please check the video and tell me if I can make a PR on this

https://user-images.githubusercontent.com/92646038/147562649-7b0d3d49-c22a-4e07-96bd-70815a7709da.mp4

Sparsh1212 commented 2 years ago

I have fixed this issue. Please check the video and tell me if I can make a PR on this

2021-12-28.17-07-12.mp4

@aritroCoder Thanks for initiating a fix. But apologies as there already has been a PR open for this issue. It's under review, so it will be unfair to the first initiator. You are most welcome to work on other open issues :)

aritroCoder commented 2 years ago

Ok no problem, I saw the PR thread was inactive for 8 days so thought to post the fix