Bookmarks Feature Implemented Using Local Storage

Sparsh1212 / gsocanalyzer

A blazingly fast tool to analyze all the selected organizations in Google Summer of Code in the form of graphical analytics.

MIT License

75 stars 39 forks source link

Bookmarks Feature Implemented Using Local Storage #45

Closed Komachian closed 2 years ago

Komachian commented 2 years ago

Fixes #36

[x] Add and delete bookmark option has been added to each organization's card
[x] A bookmarks page has been created at path='/bookmarks'
[x] The bookmarks are stored in local storage

A video snippet has been attached for reference https://user-images.githubusercontent.com/75087669/144699802-22ceb0af-b066-4bc5-bff9-f9c4c405e984.mp4

Sparsh1212 commented 2 years ago

@Komachian I must say commendable job. This is beyond amazing. Since, this is quite a big PR so please allow me some time to review it properly and with some minor iterations, this will be ready to be merged 🚀🚀🚀

Sparsh1212 commented 2 years ago

@Komachian Please take a look at the comments and also remove the merge conflicts.

Komachian commented 2 years ago

[x] Path directing behaviour modified as requested
[x] Icon svgs have been moved to src/assets
[x] Function unBook() gotten rid of
[x] Navigation and 'Reset Bookmarks' buttons made responsive
[x] 'Clear Storage' button renamed to 'Reset Bookmarks'
[x] Buttons aesthetically modified as requested
[x] Merge Conflicts Resolved

Komachian commented 2 years ago

A video snippet has been attached below https://user-images.githubusercontent.com/75087669/144976707-083dd872-3ad3-461a-8a67-ad6c1e1a48df.mp4

Komachian commented 2 years ago

The changes certainly do look in sync. The 18 commits are all the commits that were made when I first made the pull request plus every commit added by me/anyone else in the parent directory from then till now (they are listed). It seems that's because GitHub, for some reason doesn't keep track of changes to the target repository.