Closed iamrahulrnair closed 2 years ago
Also please revert all the linter warning fixes. Let's keep this PR to what the issue is about. Once, this gets fixed, we can file a separate issue to take care of all the warnings.
Also please revert all the linter warning fixes. Let's keep this PR to what the issue is about. Once, this gets fixed, we can file a separate issue to take care of all the warnings.
fix done 😄
@iamrahulrnair Please take a look at the comments added and also can you please attach a demo video that proves that it is fixing the bug.
This fix can only be tested on deployment, this is specific to GitHub-pages.
Hi, I have replaced the BrowserRouter to HashRouter, 404 page from github was due to the server not being not able to understand the subdomain with /bookmarks, only /gocanalyzer is configured in github pages, setting hashrouter remove the post # characters and possibly sending the request to github pages server as https://sparsh1212.github.io/gsocanalyzer/ hence the index.html file is obtained.😊
Out of curiosity, can you please share any reference from where you got that insight? I'd love to read more about it.
Hi, I have replaced the BrowserRouter to HashRouter, 404 page from github was due to the server not being not able to understand the subdomain with /bookmarks, only /gocanalyzer is configured in github pages, setting hashrouter remove the post # characters and possibly sending the request to github pages server as https://sparsh1212.github.io/gsocanalyzer/ hence the index.html file is obtained.😊
Out of curiosity, can you please share any reference from where you got that insight? I'd love to read more about it.
check this, read notes on client-side-routing
LGTM!
Hi, I have replaced the BrowserRouter to HashRouter, 404 page from github was due to the server not being not able to understand the subdomain with /bookmarks, only /gocanalyzer is configured in github pages, setting hashrouter remove the post # characters and possibly sending the request to github pages server as https://sparsh1212.github.io/gsocanalyzer/ hence the index.html file is obtained.😊