search

Sparsh1212 / gsocanalyzer

A blazingly fast tool to analyze all the selected organizations in Google Summer of Code in the form of graphical analytics.
MIT License
75 stars 39 forks source link

Add feature to search for multiple tags in tech and topic filter #65

Closed letsintegreat closed 2 years ago

letsintegreat commented 2 years ago

Add feature to search for multiple tags in tech and topic filter, using comma as a separator

Issue

Fixes #49

Description

Now users can search for multiple tags in tech-stack and topic by using comma separator. I have also removed the space character from sanitized search.

Type of change

Sparsh1212 commented 2 years ago

@letsintegreat Can you please upload a demo video for this PR?

Sparsh1212 commented 2 years ago

Also, as you mentioned about removing the space character from the search query, so won't that affect the search results for organizations that have a space character in their name. Wikimedia Foundation will convert to: WikimediaFoundation, this might lead to the wrong search results. WDYT?

letsintegreat commented 2 years ago

@letsintegreat Can you please upload a demo video for this PR?

https://imgur.com/a/CbJbga7

Also, as you mentioned about removing the space character from the search query, so won't that affect the search results for organizations that have a space character in their name. Wikimedia Foundation will convert to: WikimediaFoundation, this might lead to the wrong search results. WDYT?

That makes perfect sense, I think I should just remove trailing and leading spaces instead of all the spaces, so as to make comma separation work fine.

letsintegreat commented 2 years ago

@Sparsh1212 Done.

letsintegreat commented 2 years ago

@Sparsh1212 Yes, union sounds more promising. Changed.