search

SpartaSystems / holdmail

HoldMail is a Java Application for proxying SMTP mail, providing a browsable viewer for captured emails.
Apache License 2.0
34 stars 15 forks source link

Split UI code into separate module #20

Open barryoneill opened 7 years ago

barryoneill commented 7 years ago

To facilitate cleaner building but also to support switching out alternate UIs (useful for Issue #6) we should split the UI out as a separate module within the holdmail project structure.

nateprice commented 7 years ago

I have been writing the react code in a project named holdmail-fontend. We might even want to go as far as holdmail-react-front and holldmail-angular-frontend and holdmail-*-frontend. This would allow a developer to choose which front end they would like to use. The hard part if we add a new feature to one we should update all over them.

nateprice commented 7 years ago

One issue I ran into was spring boot threw a cors error. You can either annotate the endpoint or setup configuration to allow that port to be accessed. What I've read is that people use some kind of server proxy in front of spring boot. So you don't have the cors error.

barryoneill commented 7 years ago

I think it'd be confusing for people coming to the application to discover there are several competing UIs. What I'd like to do is settle on one UI framework (and one UI), but have branches containing alternatives, should we be considering a switch, or simply using holdmail as a learning project.

tsneed290 commented 7 years ago

I'd have to disagree with @barryoneill here. My scope is to test out new UI technologies. Not to replace Angular or modify the mailhold project in any way. I'm leaning more towards creating a separate project (mailhold-ui-vue) as a means to show off the different UI technology implementations.

barryoneill commented 7 years ago

Sorry, just getting to this now. Yes, confusion on my part (I thought this was Issue #6 ), another project is a great idea.