SpartaSystems / holdmail

HoldMail is a Java Application for proxying SMTP mail, providing a browsable viewer for captured emails.
Apache License 2.0
32 stars 15 forks source link

Feature/39 migrate to vuejs #40

Closed tsneed290 closed 6 years ago

tsneed290 commented 6 years ago

Short description of what this resolves:

Migrating UI from Angular to Vue

Changes proposed in this pull request:

barryoneill commented 6 years ago

This is a pretty big PR, so I'm just going to play with it locally for a while. Getting the same CI failure as Travis, notably:

28 10 2017 21:57:32.710:ERROR [config]: Invalid config file!
  Error: Cannot find module '../../build/webpack.test.conf'
    at Function.Module._resolveFilename (module.js:470:15)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/travis/build/SpartaSystems/holdmail/client/test/unit/karma.conf.js:24:21)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.parseConfig (/home/travis/build/SpartaSystems/holdmail/client/node_modules/karma/lib/config.js:363:22)
    at new Server (/home/travis/build/SpartaSystems/holdmail/client/node_modules/karma/lib/server.js:56:20)
    at Object.exports.run (/home/travis/build/SpartaSystems/holdmail/client/node_modules/karma/lib/cli.js:280:7)
    at Object.<anonymous> (/home/travis/build/SpartaSystems/holdmail/client/node_modules/karma/bin/karma:3:23)
tsneed290 commented 6 years ago

I'll dig into the failure to load the webpack configuration.

barryoneill commented 6 years ago

Ok - I've tested it out locally and it looks good! We'll have to have some followup work on styling, and also making the forward button work again, but I'd prefer not to have such a huge change sitting in a branch, looming over everything else :) Thank you @tsneed290 for all the effort!

barryoneill commented 6 years ago

Also, farewell AngularJS, you won't be missed.