search

SpartanJ / ImgurViewer

ImgurViewer is a little image viewer to open image links from external applications in the fastest way possible.
108 stars 7 forks source link

YouTube Support #74

Open sidit77 opened 1 year ago

sidit77 commented 1 year ago

I was recently thinking about adding YouTube support. I have a working prototype here using Piped including support for clips and timestamped links,

However, I think Google has a problem with 3rd party YouTube clients in the PlayStore. So this feature would have to be limited to F-Droid and Github. Do you think this could be done using some kind of conditional compilation or should I just keep this as a seperate branch and only upstream the generic changes I had to make to implement YouTube support?

SpartanJ commented 1 year ago

Oh that's awesome! This can be achieved with android build variants / flavors. That would be the correct way of doing it. I'm exited that you took the work on it. I thought of doing it several times but I'm too lazy and I'm currently paying for the premium account so I kinda lost interest. Hope you can continue working on it and we can merge it to this repo. Good luck!

sidit77 commented 1 year ago

Thanks for the quick reply. I have another question: How do you generally handle video quality? Just selecting the highest seems risky given that YouTube supports 4k videos. Maybe there should be a setting to set an upper limit like 1080p?

SpartanJ commented 1 year ago

Currently I select the highest resolution up to 1080p, ignoring anything bigger than that. But ideally I should add an option to prioritise a user-configured resolution, but I was too lazy to implement it. You can keep the same logic for the moment, use the greater resolution up to 1080p.