search

SpartanJ / ImgurViewer

ImgurViewer is a little image viewer to open image links from external applications in the fastest way possible.
112 stars 7 forks source link

Fix downloads not being saved in shared storage on android 10 and above #78

Closed starry-shivam closed 6 months ago

starry-shivam commented 6 months ago

Closes #77

SpartanJ commented 6 months ago

Awesome, thank you! Can you please reformat the file to use tabs instead of spaces so I can read the diff with more ease and also respect the project code style?

starry-shivam commented 6 months ago

Awesome, thank you! Can you please reformat the file to use tabs instead of spaces so I can read the diff with more ease and also respect the project code style?

Sure, sorry it was auto formatted by my IDE, I'll push a fix in sometime

starry-shivam commented 6 months ago

I tried to retain the original formatting; however, it seems it still isn't showing enough spaces. I don't have much experience with tabs, and I guess my IDE is not configured to support it well, but I hope it's a bit better than before

SpartanJ commented 6 months ago

Thanks again!

ihatemakinganaccount commented 5 months ago

@SpartanJ will you push a new release with this fix? (I also see there's #77... Idk what your plan is about that...)

SpartanJ commented 5 months ago

Sure, I'll do it next weekend.

ihatemakinganaccount commented 5 months ago

Neat