SpartanJ / SOIL2

SOIL2 is a tiny C library used primarily for uploading textures into OpenGL.
MIT No Attribution
370 stars 75 forks source link

Add jpg texture saving option #11

Closed SpartanJ closed 8 years ago

SpartanJ commented 8 years ago

Original report by Malte Haase (Bitbucket: a_teammate, ).


I'd love to give a pr for this but my hq capabilities are limited (and tbh im not really motivated in learning it)

so i mirrored the project to github (its really really easy: "import code" .. url_from_bitbucket and done)
and made a commit there: https://github.com/a-teammate/SOIL2-fork/commit/b48a330f498bed24b6c2028c82d1d7210f143bfb

You really have some neat libs, id love to see them somewhere they get attention ( i know im repeating myself here ^^)

(they have issue migration to github too)

SpartanJ commented 8 years ago

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


Thanks!

I thought about adding this many times but i'm not sure if makes sense to add another library to do the job. Also i'm not sure if tiny_jpeg is the best option, it looks a little bit basic ( only 3 compression quality options, minimal implementation ). In other projects I've used jpeg-compressor that works amazingly well, but it's in C++, and i'd prefer to keep the library only with C99 code. Let me think about it a little bit. I'm going to test tiny_jpeg, to see if it's good enough and i'll let you know.

Regards!

SpartanJ commented 8 years ago

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).


I ended up using jo_jpeg adapted to compile as C code. I tested tiny_jpeg side by side with jo_jpeg it gave me much worst results, so decided to use jo_jpeg that it's also smaller in code size.

Regards!

SpartanJ commented 8 years ago

Original comment by Malte Haase (Bitbucket: a_teammate, ).


Very neat, thank you!