search

SpartanJ / SOIL2

SOIL2 is a tiny C library used primarily for uploading textures into OpenGL.
MIT No Attribution
370 stars 75 forks source link

no support for sRGB images #8

Closed SpartanJ closed 8 years ago

SpartanJ commented 9 years ago

Original report by Anonymous.

SOIL2 does not set the internal format to GL_SRGB8 or GL_SRGB8_ALPHA8 when loading an sRGB texture, so the texture is treated as linear by opengl and gives in-corrected colors when rendered.

any idea when this will be added?

thanks.

SpartanJ commented 8 years ago

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).

Sorry i forgot to respond, for the moment i have no plans to support sRGB. But i'll keep it in mind for the future, sadly i don't have enough time to research about the topic and i have very little knowledge on how sRGB works. May be if this is a very trivial change and i'm getting a wrong picture about the implementation needed you can give me some tips to take a look at this topic.

Regards

SpartanJ commented 8 years ago

Original comment by Malte Haase (Bitbucket: a_teammate, ).

its basicly just the correction of the error that traditionally all displays have (they gamma correct everything they get).

these articles may help you understand that topic:

a nice introduction what linear space is about: http://filmicgames.com/archives/299

a short summary when you need what: http://stackoverflow.com/questions/24781651/when-should-i-use-gl-srgb8-instead-of-gl-rgb8

(+ another more detailed somehow related post on that topic: http://stackoverflow.com/a/10348719 )

basicly for SOIL2 the following trivial things need to be done:

Off-Topic: why don't you move to Github btw? i'd think you'd gain from such a move, since contributions are more likely over there (id guess simply bc most oss projects are there and people already got accounts, but also a bit bc of bitbuckets policies)

SpartanJ commented 8 years ago

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).

Thanks for taking the time to explain me what's all about. It really seems to be a very trivial change so i'll add it in the next days.

About Github, it's just because i like mercurial and i already have my repos here. I know that here my projects are not very exposes but migrating everything wouldn't be so easy. I would prefer to have a mirror in Github, but such service doesn't exists ( but i could use some script for that ). I'll se what i do about it. I sill prefer Bitbucket anyways ( all my private repos are here too, so it's more convenient for me ).

SpartanJ commented 8 years ago

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).

It'll be implemented, since it's trivial.

SpartanJ commented 8 years ago

Original comment by Martín Lucas Golini (Bitbucket: SpartanJ, GitHub: SpartanJ).

Added sRGB color space support. Resolved issue #8.

SpartanJ commented 8 years ago

Original comment by Malte Haase (Bitbucket: a_teammate, ).

Thanks!