Sparticuz / chromium

Chromium (x86-64) for Serverless Platforms
MIT License
846 stars 57 forks source link

TypeScript issue with `headless` param in `puppeteer-core = 22.2.0` and `@sparticuz/chromium = 122.0.0` #234

Closed turakvlad closed 3 months ago

turakvlad commented 4 months ago

It looks like new puppeteer-core expects boolean or "shell" in the headless param but @sparticuz/chromium used old "chrome-headless-shell".

Is that correct to say that we can just use true instead of chromium.headless if we use Chromium 112+?

image

Thanks!

Sparticuz commented 4 months ago

Ah, you are right. The PR that this is from is https://github.com/puppeteer/puppeteer/pull/11815. While the description of the PR states chrome-headless-shell, there is another commit that changes it to just shell.