[BUG] WithHeadings does not work with WithCustomStartCell

[tedslittlerobot]

Prerequisites

• [x] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
• [x] Checked that your issue isn't already filed.
• [x]Checked if no PR was submitted that fixes this problem.

Versions

• PHP version: 7.2
• Laravel version: 5.7
• Package version: 3.0.10

Description

If you have a custom start cell of, say B2, and headers defined, both the header and the data rows will start from B2, so the latter will overwriting the former.

Steps to Reproduce

Sample Export class:

<?php

namespace App\Exports;

use Maatwebsite\Excel\Concerns\FromCollection;
use Maatwebsite\Excel\Concerns\ShouldAutoSize;
use Maatwebsite\Excel\Concerns\WithCustomStartCell;
use Maatwebsite\Excel\Concerns\WithHeadings;
use Maatwebsite\Excel\Concerns\WithMapping;
use Maatwebsite\Excel\Concerns\WithTitle;

class RegisterExport implements FromCollection, WithHeadings, WithCustomStartCell
{
    public function headings(): array
    {
        return ['People', 1, 2, 3];
    }

    public function startCell(): string
    {
        return 'B2';
    }

    public function collection()
    {
        return collect([
            ['Person 1', 'y', 'y', 'y'],
            ['Person 2', 'y', 'y', 'y'],
        ]);
    }
}

Expected behavior:

The headers, and the data, all starting at cell B2

Actual behavior:

Only the data rendered at B2:

Also relevant, as a kind of proof of explanation, is that if you comment out the actual data rows in the above class, you get:

What is happening is that the data rows are overwriting the header rows.

I believe the cause of this is in Maatwebsite\Excel\Sheet@hasRows. The method is declared:

    /**
     * @throws \PhpOffice\PhpSpreadsheet\Exception
     * @return bool
     */
    private function hasRows(): bool
    {
        return $this->worksheet->cellExists('A1');
    }

The starting cell of A1 is hardcoded, and does not respect the custom start cell.

Possible fix: use the custom start cell value as the cell to check against, otherwise, use A1 as a default value.

Other possible fix: don't check for a single cell to test if there is a header row, test against the WithHeadings interface - which implies that there will be a row there.

Additional Information

Unconfirmed, but there still may be a related issue: In the method Maatwebsite\Excel\Sheet@append, the startCell is set (if there are already rows - ie. a header row) to $startCell = 'A' . ($this->worksheet->getHighestRow() + 1); - i believe that this should start from the custom start cell column (or perhaps resolve it by checking for the first column with content, defaulting to A?)

[patrickbrouwers]

Hey @tedslittlerobot , thanks for submitting the issue (and especially how thorough, really appreciate that!). I think it's indeed something that wasn't implemented yet (combination start row, heading row). I'll look into this soon. If in the meantime you find a good fix, feel free to PR it!

[Rohiri]

Hello, I suffered with the same, to solve it while a PR you can use AfterSheet

In your AppServiceProvider -> register

Sheet::macro('styleCells', function (Sheet $sheet, string $cellRange, array $style) {
    $sheet->getDelegate()->getStyle($cellRange)->applyFromArray($style);
 });

Use WithEvents concerns

public function registerEvents(): array
{
    return [
        AfterSheet::class    => function(AfterSheet $event) {
                $event->sheet->setCellValue('A1', 'EMPRESA');
            },
        ];
    };

[patrickbrouwers]

Will be fixed in next release

[mintunitish]

Is this fixed?

[patrickbrouwers]

Fix has been released yes

[VictorSabido]

In summary the solution is: version 3.1

public function startCell(): string
    {
        return 'B2';
    }

[PedroShimpa]

how is the solution?

[matthiascw]

@patrickbrouwers The problem persists if you work with the ShouldQueue interface.

[iqbalbaqii]

@patrickbrouwers The problem persists if you work with the ShouldQueue interface.

How is the solution?