search

SpartnerNL / Laravel-Nova-Excel

🚀 Supercharged Excel exports for Laravel Nova Resources
https://docs.laravel-excel.com/nova/1.0/
MIT License
374 stars 73 forks source link

FileNotFound after upgrade #138

Closed anditsung closed 2 years ago

anditsung commented 2 years ago

after upgrade from laravel 7 to laravel 8

when download excel file have the exception filenotfound

dont have problem on opening the file on storage/framework/cache/laravel-excel

patrickbrouwers commented 2 years ago

Not really clear what you are reporting.

anditsung commented 2 years ago

before add support for remote disk

protected function getDownloadUrl(BinaryFileResponse $response): string

after

protected function getDownloadUrl(string $filePath): string

i have a class that extend DownloadExcel to custom how it handle the download. after the update i have FileNotFound Exception

patrickbrouwers commented 2 years ago

Overriding protected methods is always at own risk. Assuming you have figured out how to fix it for your code.