SpartnerNL / Laravel-Nova-Excel

🚀 Supercharged Excel exports for Laravel Nova Resources
https://docs.laravel-excel.com/nova/1.0/
MIT License
378 stars 73 forks source link

[PROPOSAL] Implement strict null comparison #151

Open bluec opened 2 years ago

bluec commented 2 years ago

Prerequisites

Versions

Description

Can't enable strict null comparison

Steps to Reproduce

Two ways I have tried:

  1. Publish the config/excel.php from the underlying Laravel Excel package and change strict_null_comparison to true
  2. Overload the \Maatwebsite\LaravelNovaExcel\Actions\DownloadExcel class with a new class that implements the WithStrictNullComparison concern

Expected behavior:

With strict null comparison enabled, zero values in the database should export as zeros.

Actual behavior:

Zero values in the database export as null (empty cells).

Additional Information

This isn't an issue with the underlying Laravel Excel package - it works there.

I initially thought this was a bug but actually looking at the code I think it is just not implemented in this package so I have changed this to a proposal. I think it's possible to overcome this by creating a custom action but this is quite cumbersome.

Would be nice to see this implemented in the Nova package because I think it's quite important especially when dealing with Boolean fields in Laravel.