[x] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
[x] Checked that your issue isn't already filed.
[x] Checked if no PR was submitted that fixes this problem.
Versions
PHP version: 8.2.5
Laravel version: 10.9.0
Nova version: 4.24.0
Package version: 1.3.2, Laravel-Excel 3.1.48
Description
After updating to Nova 4.24.0, I immediately started getting this crash:
Symfony \ Component \ErrorHandler \ Error \ FatalError
Declaration of Maatwebsite\LaravelNovaExcel\Actions\ExportToExcel::withName(string $name) must be compatible with Laravel\Nova\Actions\Action::withName($name)
Steps to Reproduce
Straightforward inspection of the code shows this error is correct:
From LaravelNovaExcel:
public function withName(string $name)
{
$this->name = $name;
return $this;
}
From Nova:
public function withName($name)
{
$this->name = $name;
return $this;
}
While this could be fixed by removing the parameter type from the declaration, this is an inherited method that is otherwise unchanged, so it can just be deleted.
Versions
Description
After updating to Nova 4.24.0, I immediately started getting this crash:
Steps to Reproduce
Straightforward inspection of the code shows this error is correct:
From LaravelNovaExcel:
From Nova:
While this could be fixed by removing the parameter type from the declaration, this is an inherited method that is otherwise unchanged, so it can just be deleted.