search

SpatialHub-MENDELU / spatial-design-system

A set of reusable components and styles for AR and VR applications. Primary focus is on the web but general guidelines are applicable also to mobile technologies and goggles.
MIT License
2 stars 2 forks source link

New prefix for primitives #9

Open ivopisarovic opened 2 days ago

ivopisarovic commented 2 days ago

Currently, we use <a-ar- as the prefix for primitives. Our system targets all kinds of 3D apps, also VR, desktop and mobile devices. Hence, the "ar" in the prefix is not appropriate anymore. Change the prefix of all primitives to the new form and ensure backward compatibility (keep the former primitives as an alias for the ne ones).

Possible variants of new prefix:

  1. <sds-button>
  2. <a-sds-button>
  3. <s-button>
  4. <a-s-button>
  5. ???

I personally prefer variant 1.

Another question is whether to prefix also components themselves, like sds-billboard or sds-flexbox. Not sure about that.

ivopisarovic commented 2 days ago

@h0ldemslav @flecmen @terezadohnal What do you think? Which variant do you like? Or suggest yours.

flecmen commented 2 days ago

I like the first as well.

The second question, I think it depends on desired use-case of SDS. If it is supposed to be a npm package, installable and thus usable in a project, it makes sense to have the prefix everywhere, to prevent collisions in a project. It could be possible to use more design systems, each having their own implementation of flexbox.