Closed mellonnen closed 1 year ago
Merging #99 (0bbd57f) into develop (0958899) will increase coverage by
8.81%
. The diff coverage isn/a
.
Nice stuff. I think using the git client makes a lot of sense, but I do think we should double check that git is installed and reachable/usable in the system quite early when the flag is passed. One might be working on a git-folder in a remote computer/container that does not have git installed, and the error should be clear in that case.
If the
--gitignore
flag is supplied the behavior is:portal send
files in the repository will be ignored according to gitignore fileExample:
portal send gitrepository dir --gitignore
would senddir/file.txt
gitrepository/.gitignore
gitrepository/.git/
gitrepository/main.go
portal send gitrepository/somedir --gitignire
would sendgitrepository/somedir/file.go
The feature is implemented by issuing git shell commands, which reduces the complexity of writing a gitignore parser instead relying on the actual git ignore implementation. However, if we are to use this approach we would make sure to test it in other shells (other than bash and zsh) like (powershell and cmd etc).
solves #97