search

Spea / SpBowerBundle

Symfony2 Bundle to handle asset dependencies with bower
231 stars 44 forks source link

Added timeOut as possible parameter #110

Closed reypm closed 9 years ago

reypm commented 9 years ago

Will be fine if us as developers has the possibility to change the value of bower timeout parameter so I've done a small changes to fix this

Spea commented 9 years ago

Thanks for the PR, but you did a lot of code-style changes. Please refer to the symfony2 coding standards and change them (back)

Spea commented 9 years ago

Any updates?

reypm commented 9 years ago

Can I fix that through PHP CS Fixer from @fabpot or I need something else? I don't know what changes you mean the only thing I did was format code on Netbeans IDE and perhaps that made the changes you talk about

Sent from my phone using Gmail for Android On Oct 31, 2014 6:10 AM, "Martin Parsiegla" notifications@github.com wrote:

Any updates?

— Reply to this email directly or view it on GitHub https://github.com/Spea/SpBowerBundle/pull/110#issuecomment-61243626.

Spea commented 9 years ago

I'm not sure if php-cs-fixer will revert the dependency configuration but you can give it a try.

reypm commented 9 years ago

Wait a minute, what you mean with "revert the dependency configuration"? Can you point me in the right direction around that "code-style" changes you mean?

On Fri, Oct 31, 2014 at 9:00 AM, Martin Parsiegla notifications@github.com wrote:

I'm not sure if php-cs-fixer will revert the dependency configuration but you can give it a try.

— Reply to this email directly or view it on GitHub https://github.com/Spea/SpBowerBundle/pull/110#issuecomment-61259788.

Spea commented 9 years ago

I mean all the changes you made here: https://github.com/Spea/SpBowerBundle/pull/110/files#diff-850942b3ba24ab03a40aaa81b6152852L42

reypm commented 9 years ago

@Spea take a look now, I think code-styles are fixed

matheo commented 9 years ago

I may suggest you only change the lines of your interest, many CS changes here are not needed, and are not standard.

reypm commented 9 years ago

How do I know which lines are the right ones? How, if Netbeans IDE or PhpStorm IDE or any other IDE changes this do I know which one is right or not?

On Fri, Oct 31, 2014 at 2:19 PM, Mateo Tibaquirá Palacios < notifications@github.com> wrote:

I may suggest you only change the lines of your interest, many CS changes here are not needed, and are not standard.

— Reply to this email directly or view it on GitHub https://github.com/Spea/SpBowerBundle/pull/110#issuecomment-61310386.

matheo commented 9 years ago

PHP Storm hightlights the changes when you have the git repo in the project, in the other hand, I suggest you to configure your IDE to not reformat the code, grab a clean copy of the repo, change the lines of interest only, and build the pull request again... and finally, google some readings about working on GIT projects ;)

Have a good day!

Spea commented 9 years ago

You can now add any option to bower you want, see the configuration reference. This new feature makes this PR obsolete.