search

Spea / SpBowerBundle

Symfony2 Bundle to handle asset dependencies with bower
231 stars 44 forks source link

Downgrade to latest stable symfony/framework-bundle #129

Closed ghost closed 9 years ago

ghost commented 9 years ago

symfony/framework-bundle 2.8 belongs to the symfony 2.8 release which is still in development. Packages making use SpBowerBundle would before this commit require a dependency which should not be used for production quality code.

composer.lock has also been added to the repository in order to help developers test this package and ensuring they are using the same versions. Please see https://getcomposer.org/doc/02-libraries.md#lock-file for more information.

ghost commented 9 years ago

The failed builds are not a regression from this PR as far as I can see. The builds for older versions of symfony fail because of incompatible versions of ´symfony/framework-bundle`.

Spea commented 9 years ago

Please also remove the composer.lock file from this PR. The file was removed in PR #82 and should not be added again

ghost commented 9 years ago

Yeah sure but there are advantages to it being there. As an example, it would be impossible for a third developer now to download this repository and knowingly run the tests against the same versions of a package that we know works.

I think it's a better practice to manually update the dependencies when you feel like it (i.e. running composer update, verifying that it works correctly, and commit the changes).

Spea commented 9 years ago

The composer.json should make sure that the "minimal" requirements are met so the bundle can be used. Also the composer.lock will not have any effect on the projects that depend on it. And last but not least there is travis, which makes sure, that this bundle will work on every symfony version, starting from 2.1.

Some time ago I managed a composer.lock for this bundle, but it was quite annoying to do so and I personally think it is better without one.

ghost commented 9 years ago

While I do not agree I reverted the lock file. It would be good to have this fix merged as per issue 128.

Spea commented 9 years ago

I would merge it if you will change the version for symfony/framework-bundle in the composer.json as mentioned in https://github.com/Spea/SpBowerBundle/pull/129#issuecomment-113871367

ghost commented 9 years ago

Weird, I must have missed that notification somehow.