search

Spea / SpBowerBundle

Symfony2 Bundle to handle asset dependencies with bower
231 stars 44 forks source link

Fix createDependencyMappingCache for bower 1.0+ #40

Closed jankramer closed 11 years ago

jankramer commented 11 years ago

The method createDependencyMappingCache throws a MappingException when using bower 1.0+ because since this version bower list --map returns a formatted string instead of JSON by default. By using the --json option, bower is forced to return a JSON-string.

Spea commented 11 years ago

Thanks, I will take a look at this PR over the weekend

jankramer commented 11 years ago

By the way: the changelog states that --map is removed, but when running sp:bower:install it looks like unknown options are just ignored. I did a few tests and the adding of --json indeed works on both bower 0.x and bower 1.x, but this is perhaps not the cleanest solution.

Perhaps a good point to start working towards a 1.0 release and remove the --map option?

Spea commented 11 years ago

Yeah you are right, I will work towards 1.0 and remove all deprecated/removed things. I think it is time for a 1.0 release of this bundle aswell :)

omissis commented 11 years ago

Hi, I just hit this issue too :)

Spea commented 11 years ago

I'm currently working on a new version, should be finished this week

jankramer commented 11 years ago

Great! Looking forward to it! :)

Spea commented 11 years ago

I still struggle with the json of the dependency mapping. A lot has changed in 1.0, so it will take a little longer then I thought, hopefully no more than 3 days.

Spea commented 11 years ago

Sorry for the delay. I just pushed new changes to the master branch. Pleas try this version and let me know if you have any more issues. I will prepare a 1.0 release in the next days.

jankramer commented 11 years ago

:+1: I did some quick tests, and It works like a charm, thx! No worries about the delay, I appreciate the effort you put into this bundle! :)