Incorrect argument type in Bower.php

Spea / SpBowerBundle

Symfony2 Bundle to handle asset dependencies with bower

231 stars 44 forks source link

Incorrect argument type in Bower.php #45

Closed jamesmoey closed 10 years ago

jamesmoey commented 11 years ago

Catchable Fatal Error: Argument 3 passed to Sp\BowerBundle\Bower\Bower::__construct() must be an instance of Symfony\Component\EventDispatcher\EventDispatcher, instance of Symfony\Component\HttpKernel\Debug\TraceableEventDispatcher given, called in /work/avm/symfony/app/cache/dev/appDevDebugProjectContainer.php on line 4002 and defined in /work/avm/symfony/vendor/sp/bower-bundle/Sp/BowerBundle/Bower/Bower.php line 63

jamesmoey commented 11 years ago

I found the offending change in Symfony Framework Bundle on the 19 of September, commit f65a526e7. The change make sure debug event dispatcher is used everywhere when kernel.debug is on.

gigablah commented 11 years ago

Would be better to typehint to EventDispatcherInterface instead of EventDispatcher.

Spea commented 11 years ago

Yeah you right, will adjust this ASAP :)

Spea commented 11 years ago

Should be fixed in the latest master branch, let me know if you still have issues with this.