search

Spea / SpBowerBundle

Symfony2 Bundle to handle asset dependencies with bower
231 stars 44 forks source link

Empty assets for some packages #58

Closed daFish closed 10 years ago

daFish commented 10 years ago

For some of my defined packages I get only empty assets when I specify them, e.g. for "font-awesome": "~4.0".

The output of sp:bower:list for this package is the following:

@font_awesome_css
  ~
@font_awesome_js
  ~

It looks to me that the correct files cannot be found resulting in an empty asset when specified. Is this true?

Spea commented 10 years ago

Yea this is true. I fully rely on bower to get the information on where to find the assets from the packages, but if the package itself does not define where to find these assets, I'm not able to add them to the assetic resources

daFish commented 10 years ago

@Spea Thanks for the clarification. In the meantime we could support the affected packages by creating a PR adding the necessary support in the respective bower.json-files.

For Font Awesome there is already a PR: https://github.com/FortAwesome/Font-Awesome/pull/2344

Spea commented 10 years ago

Yep, that would help to improve this bundle aswell :)

daFish commented 10 years ago

Ok, thinking further upon the problem I think this can be counted as a bug in the bundle: If the real resources cannot be located then the assetic formulae don't need to be created. What do you think, @Spea?

Spea commented 10 years ago

Yeah you are right :) Removing empty formulae might be a good solution