search

Spea / SpBowerBundle

Symfony2 Bundle to handle asset dependencies with bower
231 stars 44 forks source link

Added composer.lock to gitignore #82

Closed rvanlaarhoven closed 10 years ago

rvanlaarhoven commented 10 years ago

Mainly cause I think travis would otherwise test against the possibly outdated composer.lock dependencies, in stead of the composer.json dependencies

Spea commented 10 years ago

Thanks for the PR, but I would rather change the travis.yml to use the update command from composer instead of removing the composer.lock file.

rvanlaarhoven commented 10 years ago

Ok ok. May I ask what the reason for that is? I don't really see why the lock file would be useful to anyone else. I checked several random other packages to make sure I was doing the right thing and none of them have the lock file committed.

Spea commented 10 years ago

I thought about removing it several times. Maybe it is better since I already test against different versions via travis.

If I see any disadvantages in the future, I maybe add it again :)