search

Spea / SpBowerBundle

Symfony2 Bundle to handle asset dependencies with bower
231 stars 44 forks source link

Using semver versionning pattern #83

Closed mikaelrandy closed 10 years ago

mikaelrandy commented 10 years ago

Hi folks,

I used the spBowerBundle, and i recently encountered an error, after looking in the issues list, i have found the exact answer to my problem (#79) But, unfortunately, a composer update on the spBowerBundle doesnt correct the error on my project.

After a quick search, i discover that you haven't tagged the code from 4 months, 7 commits and, unfortunately, the commit who corrects my problem.

As i think it's not good to include a composer dependancies using "dev-master" (or other "*-master"), i am looking for a clear versionning pattern who allow me to get new code quickly. I personaly use semver.

I really think your project is a really good idea, a good implementation, and i think you should follow a clear versionning pattern to improve it usability for professionnals projects.

Do you think it's possible to add this feature to your project ?

PS : i'm not an original english speaker, and my english is probably a little vague

Spea commented 10 years ago

Hey there. I will release a new version in the next days. If there are any bug-fixes in the future, I will release a new version more quickly. Sorry for the trouble ;)

mikaelrandy commented 10 years ago

Thank you for your reply, and for the news, it's great for me.

But, what do you think about using semver and tag each PR merge ?

Spea commented 10 years ago

Semver does not regulate when a new version should be tagged. All it does, is regulating what version (major, minor, patch) must be increased depending on what the new version includes (bc break, new feature, bug fix). So in some cases it is a good idea to tag new version when a PR is merged, but in other cases ist might be better to wait (because there are other pending PRs which might be useful in the next version).

Just imagine symfony would tag a new version for every PR they merge - if they would, we would have a new version or even several new versions every day :)

mikaelrandy commented 10 years ago

Yeah, i agree with you.

But the comparison with Symfony is wrong on the fact that they merge a lot a PR each week. But little projects like ours have maybe 1 PR each month.

The question i ask myself is : "is any reason to not tag this PR merge ?" and the answer is almost all the time "no" because i think all merge in master concern a stable version.

Spea commented 10 years ago

I just released a new version 0.10. Following this version I will try to release more often, following the semver versioning system.

mikaelrandy commented 10 years ago

Thank you very much !