search

SpeakAgent / lingshare

Frontend for LingShare site
MIT License
0 stars 0 forks source link

Pressing a symbol on tablets causes menu popup #60

Open blgrimley opened 9 years ago

blgrimley commented 9 years ago

In Matching and Flashcards when you press and hold a symbol image/tile on iPad it highlights the symbol and selects it so you can copy. Similar issue with wordlists, where it pops up a menu of commands.

Press and hold should be interpreted as a selection just like a tap. Younger kids are not going to know that a quick tap is the way to interact and will think the games are broken.

maljones commented 9 years ago

Will need to investigate if we can overwrite this issue cause it's a web app. iPad has some default behaviors for press and hold on webpages.

maljones commented 9 years ago

In iOS 8 and 8.1, the way to get rid of these popups has broken:

https://bugs.webkit.org/show_bug.cgi?id=136685 https://twitter.com/marcoarment/status/517380498159857665

I've added the CSS to anchor links and to a wildcard that should apply it to everything but it is not having an effect. I'm guessing it is related to the two links above.

blgrimley commented 9 years ago

Need help finding someone who might have already dealt with this kind of thing? Others have fixed it: Go to html5games.com on your iPad and play Jewelish, a match-3 Bejewelled generic game. As you press the jewels to move them, there are no popups, etc. on either iOS 7 or 8.

maljones commented 9 years ago

Yes, a game dev may likely know how to fix this.

Looking at the bejeweled clone it's not built like our games our - it's a canvas element with a lot of objects. We're using actual HTML objects (images, links, etc) so comparing the functionality is a little apples & oranges: They're both fruit and grow on trees, but are pretty different under the peel.

cwatson2014 commented 9 years ago

Is this something we can put Baron on to hunt down a solution?

On Mon, Feb 9, 2015 at 12:58 PM, Mal Jones notifications@github.com wrote:

Yes, a game dev may likely know how to fix this.

Looking at the bejeweled clone it's not built like our games our - it's a canvas element with a lot of objects. We're using actual HTML objects (images, links, etc) so comparing the functionality is a little apples & oranges: They're both fruit and grow on trees, but are pretty different under the peel.

— Reply to this email directly or view it on GitHub https://github.com/SpeakAgent/lingshare/issues/60#issuecomment-73556500.

maljones commented 9 years ago

Works for me!

On Feb 9, 2015, at 2:22 PM, cwatson2014 notifications@github.com wrote:

Is this something we can put Baron on to hunt down a solution?

On Mon, Feb 9, 2015 at 12:58 PM, Mal Jones notifications@github.com wrote:

Yes, a game dev may likely know how to fix this.

Looking at the bejeweled clone it's not built like our games our - it's a canvas element with a lot of objects. We're using actual HTML objects (images, links, etc) so comparing the functionality is a little apples & oranges: They're both fruit and grow on trees, but are pretty different under the peel.

— Reply to this email directly or view it on GitHub https://github.com/SpeakAgent/lingshare/issues/60#issuecomment-73556500.

— Reply to this email directly or view it on GitHub https://github.com/SpeakAgent/lingshare/issues/60#issuecomment-73571894.

cwatson2014 commented 9 years ago

Ben - does that work for you?

On Mon, Feb 9, 2015 at 2:23 PM, Mal Jones notifications@github.com wrote:

Works for me!

On Feb 9, 2015, at 2:22 PM, cwatson2014 notifications@github.com wrote:

Is this something we can put Baron on to hunt down a solution?

On Mon, Feb 9, 2015 at 12:58 PM, Mal Jones notifications@github.com wrote:

Yes, a game dev may likely know how to fix this.

Looking at the bejeweled clone it's not built like our games our - it's a canvas element with a lot of objects. We're using actual HTML objects (images, links, etc) so comparing the functionality is a little apples & oranges: They're both fruit and grow on trees, but are pretty different under the peel.

— Reply to this email directly or view it on GitHub < https://github.com/SpeakAgent/lingshare/issues/60#issuecomment-73556500>.

— Reply to this email directly or view it on GitHub < https://github.com/SpeakAgent/lingshare/issues/60#issuecomment-73571894>.

— Reply to this email directly or view it on GitHub https://github.com/SpeakAgent/lingshare/issues/60#issuecomment-73572073.

maljones commented 9 years ago

We're putting this issue on hold as it seems the fix for all interactions will bump the level of effort up way high. During the alpha we'll come back to look at this.

maljones commented 9 years ago

Working on merging #68 - restyling CSS in header.

maljones commented 9 years ago

Same comment as in #68. I merged the fix with jones0005 and restyled the nav. There is a bug when you click on the logo though - it goes to 'undefined' as opposed to the dashboard. Removing the image and replacing it with text solves the bug. Don't know why it's happening, need Baron to check it out.