Closed schnerring closed 4 years ago
Man, you're on fire!
Have you tested these changes on an actual drive?
31def99 changes 2<&1 (input redirection) to 2>&1 (output redirection). I'm pretty sure that this was a mistake, and not some shell magic I don't understand?
You're asking me? Didn't you write this code? :-)
Anyway, yes, it does look like an error.
would it be helpful to add / update the repo's dry-run logs like burnin-HGST_HUS724020ALE640_PKXXXXXXXXXXXX.log?
Sure, we can update the sample dry-run output. Would be a good idea, as it would show actual output from the current version.
Man, you're on fire!
So far, I really enjoy bash scripting. It's really different from object oriented programming.
Have you tested these changes on an actual drive?
I aborted the run from the last PR and restarted it on my four Seagate IronWolf NAS HDD 12TB (ST12000VN0008)
drives. It's running badblocks
right now. It will take a couple of days until those are finished.
I've also tested the dry-run option on those, as well as my SSDs and mechanical drive of my development machine.
You're asking me? Didn't you write this code? :-)
Those redirects were always around, as is.
Sure, we can update the sample dry-run output. Would be a good idea, as it would show actual output from the current version.
Added an updated version.
The rest from my "TODO" list.
I went ahead and added the Seagate IronWolf 12 TB to tested disks. I'm currently burning them in with this PR's version.
Changes
dry_run_wrapper()
<disk>
option to besdX
or/dev/sdX
-h
)elp option. Also added (-e
)xtended help option to display the whole textbadblocks
for non-mechanical drivesQuestions
2<&1
(input redirection) to2>&1
(output redirection). I'm pretty sure that this was a mistake, and not some shell magic I don't understand?