SpecFlowOSS / SpecFlow.Actions

BSD 3-Clause "New" or "Revised" License
57 stars 53 forks source link

[Playwright] released package has wrong dependencies (configuration plugin) #71

Closed le-yams closed 2 years ago

le-yams commented 2 years ago

Hello,

SpecFlow.Actions.Playwright 0.1.258 was released a few hours ago but its dependencies seems to be wrong regarding the specflow configuration plugin.

It seems that it points to the same version:

SpecFlow.Actions.Configuration.SpecFlowPlugin (>= 0.1.258)

but this one does not exist. SpecFlow.Actions.Configuration.SpecFlowPlugin latest is 0.1.250 (and is also marked as deprecated).

Here is the error I get when trying to install SpecFlow.Actions.Playwright 0.1.258:

Unable to find package SpecFlow.Actions.Configuration.SpecFlowPlugin with version (>= 0.1.258)

  • Found 1 version(s) in nuget.org [ Nearest version: 0.1.250 ]

Thank you in advance :)

Regards, Yann

CyborTronik commented 2 years ago

Same issue on ubuntu

andrewmk commented 2 years ago

Same here - I'm stuck using SpecFlow.Actions.Playwright version 0.1.178 and can't upgrade to 0.1.258 because of the wrong dependency.

304NotModified commented 2 years ago

Indeed, this package is broken! @SabotageAndi

SabotageAndi commented 2 years ago

fixed with #74 - upload to NuGet.org is done within the hour

le-yams commented 2 years ago

@SabotageAndi Thanks for the update :)

But, after updating to SpecFlow.Actions.Playwright 0.1.281, I now have an error during the project build (it disappears when I rollback to SpecFlow.Actions.Playwright 0.1.178)

SpecFlow.Tools.MsBuild.Generation.targets(93, 5): [MSB4018] Échec inattendu de la tâche "GenerateFeatureFileCodeBehindTask".
System.IO.FileNotFoundException: Could not load file or assembly 'SpecFlow.Actions.Configuration.SpecFlowPlugin, Version=0.1.0.0, Culture=neutral, PublicKeyToken=null'. Le fichier spécifié est introuvable.
File name: 'SpecFlow.Actions.Configuration.SpecFlowPlugin, Version=0.1.0.0, Culture=neutral, PublicKeyToken=null'
   at SpecFlow.Actions.Configuration.Generation.TargetsGeneratorPlugin.GeneratorPluginEvents_CustomizeDependencies(Object sender, CustomizeDependenciesEventArgs e)
   at TechTalk.SpecFlow.Generator.Plugins.GeneratorPluginEvents.RaiseCustomizeDependencies(ObjectContainer container, SpecFlowProjectConfiguration specFlowProjectConfiguration)
   at TechTalk.SpecFlow.Generator.GeneratorContainerBuilder.CreateContainer(SpecFlowConfigurationHolder configurationHolder, ProjectSettings projectSettings, IEnumerable`1 generatorPluginInfos, IObjectContainer parentObjectContainer)
   at SpecFlow.Tools.MsBuild.Generation.WrappedGeneratorContainerBuilder.BuildGeneratorContainer(SpecFlowConfigurationHolder specFlowConfigurationHolder, ProjectSettings projectSettings, IReadOnlyCollection`1 generatorPluginInfos, IObjectContainer rootObjectContainer)
   at SpecFlow.Tools.MsBuild.Generation.GenerateFeatureFileCodeBehindTaskExecutor.Execute()
   at SpecFlow.Tools.MsBuild.Generation.GenerateFeatureFileCodeBehindTask.Execute()
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

Could it be related to the SpecFlow.Actions.Configuration 0.1.281 transitive dependency? (I'm seeing a SpecFlow.Actions.Configuration.SpecFlowPlugin.dll in its nuget package lib subfolders)

Should I open a new issue?

SabotageAndi commented 2 years ago

Grml, stupid MSBuild Assembly loading. I will check it tomorrow

andrewmk commented 2 years ago

I can confirm that I've successfully updated SpecFlow.Actions.Playwright to 0.1.258 and everything seems to work as it should. Thanks.

SabotageAndi commented 2 years ago

@le-yams I can't reproduce your issue. I added a new example project for Playwright (https://github.com/SpecFlowOSS/SpecFlow-Examples/tree/master/Actions/PlaywrightExample) and this is working.

Please open a new issue. Looks like it is something different,