Update to .NET 8 - Githubissues

SpecFlowOSS / SpecFlow.VS

The next version of the Visual Studio extension for SpecFlow

MIT License

36 stars 10 forks source link

Update to .NET 8 #146

Closed marcel-tatasteel closed 8 months ago

marcel-tatasteel commented 8 months ago

Types of changes

[ X ] Other (docs, build config, etc)
Update to .NET 8.0
Update from 472 => 481

Checklist:

[ X ] I've added tests for my code. (most of the time mandatory)

marcel-tatasteel commented 8 months ago

@gasparnagy Could you take a look at this PR?

gasparnagy commented 8 months ago

@marcel-tatasteel Thx for the PR. Do you have an idea why the tests fail on the CI? Does those work fine locally?

marcel-tatasteel commented 8 months ago

@gasparnagy Locally all tests are green, seems like something in the build pipeline broke. (previous autobot updates also fail)

marcel-tatasteel commented 8 months ago

@gasparnagy Locally test now also fail because of an update of nUnit to 4.0.0 which does not support net45 anymore.

-> error: Could not find a part of the path 'C:\Users\AppData\Local\Temp\DeveroomTest\DS_Gen875le_2.4.1_nunit_1194832604\packages\NUnit.4.0.0\lib\net45'. (2,1s)

gasparnagy commented 8 months ago

@marcel-tatasteel if you check back the stacktrace, you can maybe find the code that uses "net45" now for the path, you can change that to anything that is supported now with nunit. Let's see

marcel-tatasteel commented 8 months ago

@gasparnagy Will try to fix the tests

marcel-tatasteel commented 8 months ago

@gasparnagy Because the 'ApprovalTest' updates nUnit to 4.0.0, all nUnit approval test <net461 or <net60 will fail. See changelog nUnit: Supported platforms:

.NET Framework 4.6.2+
.NET 6.0+

3 options =>

force nUnit 3 for older frameworks
Drop testsupport for older versions and only approval test for net462+ and net6.0+
Use nUnit 3 for older frameworks and use nunit 4 for newer.....

Let met know.

gasparnagy commented 8 months ago

@marcel-tatasteel I guess option 1) suppose to be "force nUnit 4 for older frameworks" or was it "force nUnit 3 for newer frameworks"?

mountain65 commented 8 months ago

Personally I love moving forward, so I would choose option 2). But I can imagine that you look at that differently as OS project manager.

gasparnagy commented 8 months ago

@marcel-tatasteel i tend to agree. which frameworks would we lose if we would drop those tests?

marcel-tatasteel commented 8 months ago

@gasparnagy Got some spare time to fix the build pipeline. After several commits, all tests are now green.

Made a switch between nUnit 4 and nUnit 3 ( NUnit 4 only supports >= net6 and >= net462 )
Commented out 2 tests
1. ConnectorInvestigation test (was only there for investigation)
2. Discover bindings from a SpecFlow project on .NET Framework => | line-v3.0 | v3.0.225 | (somehow v3.0.225 gives problems)
  - Added more .net 8 tests and also added some newer specflow version

gasparnagy commented 8 months ago

@marcel-tatasteel Thank you very much! Great work!

I try to somehow arrange with Tricentis that it get's released ASAP.

gasparnagy commented 8 months ago

Fixes #145

gasparnagy commented 8 months ago

Until it will be published to the marketplace, you can install this version from the VSIX file attached to the release: https://github.com/SpecFlowOSS/SpecFlow.VS/releases/tag/v2022.1.93-net8

vjagwani-nc commented 1 week ago

@gasparnagy the VSIX file has not resolved the issue, still facing the same issue.

gasparnagy commented 1 week ago

@vjagwani-nc Use the Reqnroll extension instead. It works with SpecFlow too. https://marketplace.visualstudio.com/items?itemName=Reqnroll.ReqnrollForVisualStudio2022