Generate step definitions ignores step

aliensqueegee commented 5 years ago

SpecFlow Version:

[x] 3.1.42-beta
[x] 3.1.32-beta
[ ] 3.0
[ ] 2.4
[ ] 2.3
[ ] 2.2
[ ] 2.1
[ ] 2.0
[ ] 1.9

Used Test Runner

[ ] SpecFlow+Runner
[ ] MSTest
[ ] NUnit
[x] Xunit

Version number: 2.4.1

Project Format of the SpecFlow project

[ ] Classic project format using packages.config
[x] Classic project format using <PackageReference> tags
[ ] Sdk-style project format

.feature.cs files are generated using

[x] SpecFlow.Tools.MsBuild.Generation NuGet package
[ ] SpecFlowSingleFileGenerator custom tool

Visual Studio Version

[x] VS 2019
[ ] VS 2017
[ ] VS 2015

`Enable SpecFlowSingleFileGenerator Custom Tool` option in Visual Studio extension settings

[ ] Enabled
[x] Disabled

Are the latest Visual Studio updates installed?

[x] Yes
[ ] No, I use Visual Studio version <Major>.<Minor>.<Patch>

.NET Framework:

[ ] >= .NET 4.5
[ ] before .NET 4.5
[ ] .NET Core 2.0
[ ] .NET Core 2.1
[ ] .NET Core 2.2
[x] .NET Core 3.0

Test Execution Method:

[x] Visual Studio Test Explorer
[ ] TFS/VSTS/Azure DevOps – Task – PLEASE SPECIFY THE NAME OF THE TASK
[ ] Command line – PLEASE SPECIFY THE FULL COMMAND LINE

<SpecFlow> Section in app.config or content of specflow.json

{
  "bindingCulture": {
    "language": "en-us"
  },
  "language": {
    "feature": "en-us"
  },
  "trace": {
    "stepDefinitionSkeletonStyle": "MethodNameUnderscores"
  },
  "plugins": []
}

Repro Project

Issue Description

I have two feature files in my test project.

first feature file has a single Scenario with one Then clause that ends with string 'test'
second feature file has a similar Scenario with one Then clause, but ends with 'test' text that will be ignored

The issue is that everything after 'test' string is ignored when generating step definitions. You get the message All steps are bound! when you try to generate step definitions. In the second feature file I notice that text that will be ignored is italic and gray. It's like it's considering text that will be ignored to be part of the parameter 'test'

Steps to Reproduce

Step 1:

Create first feature file Calculator.feature


Feature: Calculator
In order to avoid silly mistakes
As a math idiot
I want to be told the sum of two numbers

@Calculator Scenario: Add two numbers Given I have entered 50 into the calculator And I have entered 70 into the calculator When I press add Then the result should be 120 on the screen and message 'test'

- Generate Step Definitions 
``` csharp
using System;
using TechTalk.SpecFlow;

namespace SpecFlowTests
{
    [Binding]
    public class CalculatorSteps
    {
        [Given]
        public void Given_I_have_entered_P0_into_the_calculator(int p0)
        {
            ScenarioContext.Current.Pending();
        }

        [When]
        public void When_I_press_add()
        {
            ScenarioContext.Current.Pending();
        }

        [Then]
        public void Then_the_result_should_be_P0_on_the_screen_and_message_P1(int p0, string p1)
        {
            ScenarioContext.Current.Pending();
        }
    }
}

Step 2:

Create second feature file CalcultatorV2.feature


Feature: CalculatorV2
In order to avoid silly mistakes
As a math idiot
I want to be told the sum of two numbers

@CalculatorV2 Scenario: Add two numbers Given I have entered 50 into the calculator And I have entered 70 into the calculator When I press add Then the result should be 120 on the screen and message 'test' text that will be ignored

- Generate Step Definitions returns **All steps are bound!**
``` csharp

Everything after 'test' string is ignored

SabotageAndi commented 5 years ago

Could you post also the generated bindings please?

aliensqueegee commented 5 years ago

@SabotageAndi I've updated issue description

SabotageAndi commented 5 years ago

Ah, you are using the method names to do the binding. Some stuff doesn't work with them. I would suggest to switch back to the definition via regular expressions.

aliensqueegee commented 5 years ago

@SabotageAndi it's working fine with regular expression definition style for this PoC project. Changing a whole project from one method name style to regular expresion might be a little to much for me right now. Any chance that this bug will be fixed for method name definition style in the near future?

SabotageAndi commented 5 years ago

If not somebody sends a PR with a fix, I don't think this will fixed soon. Currently we (as in SpecFlow Team) don't have any work planned around method name definition. It's a rarely used feature and we are only a small team with limited time and resources. Sorry.

SpecFlowOSS / SpecFlow