Skip.If() is not possible in BeforeScenarioHook

[SabotageAndi]

SpecFlow Version:

• [x] 3.1
• [ ] 3.0
• [ ] 2.4
• [ ] 2.3
• [ ] 2.2
• [ ] 2.1
• [ ] 2.0
• [ ] 1.9

Used Test Runner

• [ ] SpecFlow+Runner
• [ ] MSTest
• [ ] NUnit
• [x] Xunit

Version number:

Project Format of the SpecFlow project

• [ ] Classic project format using packages.config
• [ ] Classic project format using <PackageReference> tags
• [x] Sdk-style project format

.feature.cs files are generated using

• [ ] SpecFlow.Tools.MsBuild.Generation NuGet package
• [ ] SpecFlowSingleFileGenerator custom tool

Visual Studio Version

• [x] VS 2019
• [ ] VS 2017
• [ ] VS 2015

Enable SpecFlowSingleFileGenerator Custom Tool option in Visual Studio extension settings

• [ ] Enabled
• [x] Disabled

Are the latest Visual Studio updates installed?

• [x] Yes
• [ ] No, I use Visual Studio version <Major>.<Minor>.<Patch>

.NET Framework:

• [ ] >= .NET 4.5
• [ ] before .NET 4.5
• [ ] .NET Core 2.0
• [ ] .NET Core 2.1
• [ ] .NET Core 2.2
• [x] .NET Core 3.1

Test Execution Method:

• [x] Visual Studio Test Explorer
• [ ] TFS/VSTS/Azure DevOps – Task – PLEASE SPECIFY THE NAME OF THE TASK
• [ ] Command line – PLEASE SPECIFY THE FULL COMMAND LINE

<SpecFlow> Section in app.config or content of specflow.json

Repro Project

1. standard xUnit SpecFlow project
2. add this hook

   [BeforeScenario()]
   public void BeforeScenario()
   {
   Skip.If(true);
   }

3. run tests

4. 

Issue Description

The Scenario should be skipped.
This works for bindings, but not for hooks.

[bklebe]

I would just like to add that I don't know about Skip.If() in xUnit but I used IUnitTestRuntimeProvider.TestIgnore as per https://docs.specflow.org/projects/specflow/en/latest/Execution/SkippingScenarios.html with NUnit in a BeforeScenario hook scoped to a specific tag and it seemed to work fine. Perhaps the documentation should be updated to say this limitation is xUnit-specific?

[SabotageAndi]

@bklebe Thanks for the info. The documentation page for it is here: https://github.com/SpecFlowOSS/SpecFlow/blob/master/docs/Execution/SkippingScenarios.md Would you adjust the documentation with this information?

[bklebe]

Happy to.