[ExternalDataPlugin] Fix build via 'dotnet build'

SpecFlowOSS / SpecFlow

#1 .NET BDD Framework. SpecFlow automates your testing & works with your existing code. Find Bugs before they happen. Behavior Driven Development helps developers, testers, and business representatives to get a better understanding of their collaboration

https://www.specflow.org/

Other

2.24k stars 754 forks source link

[ExternalDataPlugin] Fix build via 'dotnet build' #2503

Closed kazantsev033 closed 2 years ago

kazantsev033 commented 2 years ago

Types of changes

Fix #2496

Added .deps.json file into nuget package

Before:

After:

Added missing dependencies into SpecFlow.ExternalData.nuspec

[X] Bug fix (non-breaking change which fixes an issue).

SabotageAndi commented 2 years ago

I am not a big fan of CopyLocalLockFileAssemblies as it burned us in the past. Is it really needed to be set?

kazantsev033 commented 2 years ago

I am not a big fan of CopyLocalLockFileAssemblies as it burned us in the past. Is it really needed to be set?

No. I have found a better (IMHO) way to fix it.

If there are no some necessary packages in nuget packages folder (C:\Users\.nuget\packages in my case) or in nuget package itself, there will be an error during a build.

To be placed in nuget packages folder these packages have to be added as a dependencies into .nuspec file. Also .deps.json has to be added into nuget package.