SpecFlowOSS / SpecFlow

#1 .NET BDD Framework. SpecFlow automates your testing & works with your existing code. Find Bugs before they happen. Behavior Driven Development helps developers, testers, and business representatives to get a better understanding of their collaboration
https://www.specflow.org/
Other
2.23k stars 752 forks source link

Make XUnit2TestGeneratorProvider.SetTestMethod virtual #2555

Closed JoshKeegan closed 2 years ago

JoshKeegan commented 2 years ago

Make XUnit2TestGeneratorProvider.SetTestMethod virtual so that it can be replaced by generator plugins. I needed to make this change for a new feature in my generator plugin, src using it here: https://github.com/JoshKeegan/xRetry/blob/5494809b736bc50c8bcdf24ece71b6623a2f6d4c/src/xRetry.SpecFlow/TestGeneratorProvider.cs#L35

Types of changes

Checklist:

SabotageAndi commented 2 years ago

Sure, no problem to make this virtual.

SabotageAndi commented 2 years ago

@JoshKeegan this change is released to nuget.org

JoshKeegan commented 2 years ago

@JoshKeegan this change is released to nuget.org

Thanks!