add DateTimeStyles to DateTime(Offset)ValueRetriever

SpecFlowOSS / SpecFlow

#1 .NET BDD Framework. SpecFlow automates your testing & works with your existing code. Find Bugs before they happen. Behavior Driven Development helps developers, testers, and business representatives to get a better understanding of their collaboration

https://www.specflow.org/

Other

2.23k stars 752 forks source link

add DateTimeStyles to DateTime(Offset)ValueRetriever #2565

Closed bollhals closed 2 years ago

bollhals commented 2 years ago

This change adds a way to modify the DateTimeStyles used when parsing.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Performance improvement
[ ] Refactoring (so no functional change)
[ ] Other (docs, build config, etc)

Checklist:

[x] I've added tests for my code. (most of the time mandatory)
[x] I have added an entry to the changelog. (mandatory)
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

SabotageAndi commented 2 years ago

I like this idea. Would you have some time to add a paragraph to https://github.com/SpecFlowOSS/SpecFlow/blob/master/docs/Bindings/Step-Argument-Conversions.md?

bollhals commented 2 years ago

Sure, will update the docs and forward integrate 👍

bollhals commented 2 years ago

I like this idea. Would you have some time to add a paragraph to https://github.com/SpecFlowOSS/SpecFlow/blob/master/docs/Bindings/Step-Argument-Conversions.md?

@SabotageAndi But this isn't used for Step-Argument-Conversions is-it? Should I add it to SpecFlow.Assist-Helpers?

SabotageAndi commented 2 years ago

@bollhals You are completely right.

bollhals commented 2 years ago

Can you check if the doc is fine for you?

SabotageAndi commented 2 years ago

Perfect @bollhals!