Integrating PR 1614 - Githubissues

gasparnagy commented 2 years ago

This is a temporary PR for checking integration possibilities of #1614

gasparnagy commented 2 years ago

Notes:

Shall we keep Steps.Given & co.? Shall we add Steps.GivenAsync (it is added now)? Shall we mark it as obsolete?

gasparnagy commented 2 years ago

Integration status:

All issues are hopefully cleared now, locally all .NET 6 Specs tests pass now and they run again parallel. 😄
There is a known CI issue, that is addressed by #2583. Once that is green and merged, hopefully the CI gets green as well.

TODO (after Easter):

gasparnagy commented 2 years ago

Green build! Hurray!

gasparnagy commented 2 years ago

Status today:

Async behavior and backwards compatibility checked using manual exploratory testing (basic xUnit, MsTest, NUnit projects, compatibility check with a real project).
TODOs are removed

Notes:

I have removed the Microsoft.Bcl.AsyncInterfaces because we only used it for one class and it might cause versioning problems for .NET 4 (see here). The Microsoft.Bcl.AsyncInterfaces reference addition can be removed now from TestProjectGenerator, I think, but I haven't removed it yet.
Good news: SpecFlow.Plus.LivingDoc v3.9.57 seem to work fine with the new version (unused steps are also found correctly)
Bad news: VS2022 does not work, as expected

Next steps:

//cc @SabotageAndi

SabotageAndi commented 2 years ago

Master is bumped to 3.10-beta