#2608: Await the call to FeatureBackgroundAsync - Githubissues

SpecFlowOSS / SpecFlow

#1 .NET BDD Framework. SpecFlow automates your testing & works with your existing code. Find Bugs before they happen. Behavior Driven Development helps developers, testers, and business representatives to get a better understanding of their collaboration

https://www.specflow.org/

Other

2.22k stars 752 forks source link

#2608: Await the call to FeatureBackgroundAsync #2654

Closed laingsimon closed 1 year ago

laingsimon commented 1 year ago

Ensure that calls to FeatureBackgroundAsync are awaited when called, i.e.

Instead of this

// ... snip ...
#line 4
    this.FeatureBackgroundAsync();
#line hidden
// ... snip ...

Generate this

// ... snip ...
#line 4
    await this.FeatureBackgroundAsync();
#line hidden
// ... snip ...

Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Performance improvement
[ ] Refactoring (so no functional change)
[ ] Other (docs, build config, etc)

Checklist:

[ ] I've added tests for my code. (most of the time mandatory)
[ ] I have added an entry to the changelog. (mandatory)
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Note: I've not added tests or an entry to the change log for the following reasons:

There are no existing tests for the UnitTestMethodGenerator; if you require them then i can have a look to create some
I've not added an entry to the changelog as this fixes a change within the 4.0.16-beta version, as such it fixes an issue during the beta. Once again if this is required, please let me know and i'll add something in.

laingsimon commented 1 year ago

Manual tests performed:

Build TechTalk.SpecFlow.Generator project
Copy <repo>\TechTalk.SpecFlow.Generator\bin\Debug\netcoreapp3.1\TechTalk.SpecFlow.Generator.dll over %userprofile%\.nuget\packages\specflow.tools.msbuild.generation\4.0.16-beta\tasks\netcoreapp3.1\TechTalk.SpecFlow.Generator.dll
Rebuild client project
Observe a change to the built xxx.feature.cs file in client project

Before

#line 4
    this.FeatureBackgroundAsync();
#line hidden

After

#line 4
    await this.FeatureBackgroundAsync();
#line hidden