Closed clrudolphi closed 1 year ago
Open to suggestions for improvements. I will be adding tests to the Specs project. Considering adding a dedicated unit test project for this -- let me know whether you think that worthwhile.
@gasparnagy Thank you so much for the review comments and suggestions! I've incorporated your suggestions, resulting in a greatly simplified implementation (largely isolated to the SPH). Would welcome any further suggestions you might have.
I am having a problem with adding a Feature file to the SpecFlow.Specs tests however. Pls see my latest commit to this PR (#565afff). When executed the test fails with a TechTalk.SpecFlow.BindingException "Ambiguous step definitions..." The exact error message related to the first scenario of the feature file is: Error Message: TechTalk.SpecFlow.BindingException : Ambiguous step definitions found for step 'Given something first as background': DefaultTestProject:RuleSteps1.GivenSomethingFirst(), DefaultTestProject:BindingsClass_76ec255a.StepBinding() Stack Trace: at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.GetStepMatch(StepInstance stepInstance)
Any suggestions?
@gasparnagy never mind on the problem with ambiguous step definitions; I figured it out. My problem :).
This PR ready for final review/approval.
Please remove that one scenario and then we are ready to go, i think.
Removed. This feature file now reverted to what is in Master.
@gasparnagy @SabotageAndi - checking in with you on this. I believe all prior suggestions/concerns are addressed. Are there any other changes you would like to see?
@clrudolphi Thx! It took a bit more time... sry
@SabotageAndi great news! awesome feature! Congrats.
Has this already been released? Can't see it working in latest SpecFlow for Visual Studio 2022 released Dec 20 2022
Has this already been released? Can't see it working in latest SpecFlow for Visual Studio 2022 released Dec 20 2022
It was incorporated into the v4.0.31-beta build (built on 15 Dec 22).
This PR adds support for Rule Backgrounds.
Most of the additional logic has been added to the ScenarioPartHelper class:
Types of changes
Checklist: