search

SpecOps2016 / pe

0 stars 0 forks source link

Legitimate Names Not Allowed For Add #1

Open SpecOps2016 opened 2 years ago

SpecOps2016 commented 2 years ago

image.png

Legitmates names e.g. Sundra s/o Samimoorthy should be allowed in the add function. Not allowing names like this to be added can be considered a feature flaw.

Steps to reproduce: add n/Sundra s/o Samimoorthy p/98765432 e/johnd@example.com a/John street, block 123, #01-01s/OA in Progress st/Java dt/Bachelors jt/Internship rate/4

nus-se-bot commented 2 years ago

Team's Response

Although this is a valid bug, we believe it is Not In Scope of our application as CLInkedIn is just a recruitment application management and tracking app that doesn't require legal names of candidates as it is not part of any official recruitment process of any company.

Moreover, in this particular case, s/ is already a prefix for status, and we also allow users to create their own tag types and prefixes. Hence, allowing characters like / and - isn't reasonable to parse the commands properly.

Also, it is not a feature that we implemented in v1.4, or a feature that our app aims to provide, plus we also display an appropriate error message to make the user aware of the accepted format for name. Hence, we feel this bug is not in scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Definitely in scope. This is an issue as names that are inputted into the databse, as long as valid, should be accepted regardless of legal or not. If legal names were not allowed, perhaps full names of all candidates should not be allowed to be entered into the app, but this will make no sense at all. Disallowing valid names to be entered into the system is user unfriendly, especially in the case of "Sundra s/o Samimoorthy", the alternative will be to key in "Sundra", and this name will reduce the uniqueness of the candidate, especially if there are a lot of "Sundra" in the database.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: This will cause significant problems especially with Indian names. Since one can assume that there are quite a substantial number of Indian candidates, this bug will definitely cause significant inconvenience.