search

SpeciLiam / pe

0 stars 0 forks source link

Exception does not descirbe the problem at hand #11

Open SpeciLiam opened 1 year ago

SpeciLiam commented 1 year ago

image.png

Exchanging 2,000,000 USD to joy is clearly over "10,000,000" which is the intended limit so that is fine, but the therein lies with the exception throw it is describing it as if I was adding or depositing when in reality I was exchanging.

nus-pe-bot commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Depositing can be understood to mean any action that describes adding money to an account, which would include both the add and exchange command. The error message also asks the user to check how much they would be depositing, which means they can use the show-rate command to see that exchanging 2m USD to JPY is over 10m.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]