search

SpeciLiam / pe

0 stars 0 forks source link

Does not throw correct excpetion #7

Open SpeciLiam opened 1 year ago

SpeciLiam commented 1 year ago

image.png

Even though the 31st of February does not exit it should accept because it states it will accept from 0-31 for days

nus-se-script commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

The same error message is used for an invalid format and an invalid input, duplicated issue. The fact that it does not accept is functioning as intended.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error message for trans

Screenshot 2023-04-14 at 4.52.38 PM.png Error message could be more accurate in describing that the month is invalid rather than claiming that the format is wrong. The same improvement can be made when user inputs an invalid year. Similarly, this applies to the trans d command.

[original: nus-cs2113-AY2223S2/pe-interim#2691] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

You are right perhaps there could be a more specific error message for this case. However differentiating between incorrect format and invalid format is out of scope.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]