Closed binHarby closed 1 year ago
Alright I fixed the whole thing, and rewrote the form to be mobile-friendly, with this, I fixed #69 #67 and #68 which are similar.
Moutasim so this means that you have already fixed these ? if you did so how can i review the fixed code?
Because I was working on it yesterday but I did't notice that you were working on it as well, and I fixed everything.
@fatimaalneyadi Yes this is already fixed, you can check out to UserSettingsFooter branch, and have a look, but you can see this screenshot too.
@Moutasim02 I will fix the icons so that it will appear like this:
@fatimaalneyadi You can fix the icons over my work, I didn't notice the missing icons in my branch until now, that's due to the use of an inappropriate font awesome icons version from your side, please follow the standard, we are only using version 4.7 as you can see from most
sections in all pages.@Moutasim02 I did fixed the icons but when i run it the layout didn't appear the same as ur screenshoot although i have input the global, footer, navbar, and user setting css. Do you know how can i fix it, maybe i missed something
@fatimaalneyadi Better make a new branch from master as abdullah already merged UserSettingsFooter branch, and from that one you can push the changes and make a PR.
Solved with #79
Copy footer from Browse Users, make sure to also copy the general css files, Footer Navbar and Global