search

SpeciesFileGroup / INHS-Insect-Collection-Data-Curation

An accesible issue tracker for reporting issues or requests with respect to INHS data quality.
2 stars 0 forks source link

Add missing dates to loans #3

Open tmcelrath opened 3 months ago

tmcelrath commented 3 months ago

When I use Filter loans to search for:

  1. All loans: 3547 loans: https://sfg.taxonworks.org/tasks/loans/filter?per=50&page=1

  2. Overdue loans: 645 loans: https://sfg.taxonworks.org/tasks/loans/filter?per=50&overdue=true&page=1

  3. Not overdue loans: 68 loans: https://sfg.taxonworks.org/tasks/loans/filter?per=50&overdue=false&page=1

Loans are boolean, either overdue or not overdue. We therefore have 2834 loans that are neither - which is impossible. But I cannot search for them. I THINK it is because they are missing some of the "Dates" to calculate these values, since they were legacy imported. @mjy1 @proceps we need a way to find these via loan filter, or we need to go through the loans 1 by 1 and fill out documentation.

tmcelrath commented 3 months ago

From @proceps: returned loans are not overdue. Probably, there should be another option (active/returned).

tmcelrath commented 3 months ago

https://github.com/SpeciesFileGroup/taxonworks/issues/3729 & https://github.com/SpeciesFileGroup/taxonworks/issues/3728 are related/need fixed.

proceps commented 3 months ago

We have 4 dates on each loan: date_requested; date_sent; date_return_expected; date_closed. If there are filtering option for each of those date, you should be able to get all information. Loans without date_closed should give you a list of active loans.

tmcelrath commented 3 months ago

Waiting on TW development: https://github.com/SpeciesFileGroup/taxonworks/issues/3729