search

SpeciesFileGroup / nomen

A nomenclatural ontology for names (not concepts).
The Unlicense
11 stars 1 forks source link

Fixes spelling error of ICNP #13

Closed hlapp closed 5 years ago

hlapp commented 5 years ago

I would assume that ICNB is a spelling error of ICNP that was subsequently propagated through copy&paste? That's assuming that it's not a misspelling of ICBN, because it seems that has become ICN.

mjy commented 5 years ago

@proceps can you confirm? Remarkably there "official" acronym for these things is very hard to figure out.

mjy commented 5 years ago

@proceps This reminds me that this might have consequences for corresponding constant labels in TaxonWorks (and that we need a unit test to validate that we maintain the linkages properly).

proceps commented 5 years ago

Bacterial code changed it name to the International Code of Nomenclature of Prokaryotes (so ICNB > ICNP) I changed all the Constants in TW (and tests).

mjy commented 5 years ago

@proceps 'ICNB > ICNP' means use "ICNP", right?

hlapp commented 5 years ago

ICNP is the name you use in the scientific name hierarchy, so no matter which one is right, it should arguably be the same that you're using :-)

proceps commented 5 years ago

Yes ICNP is the right name of the code now