SpeciesFileGroup / taxonworks

Workbench for biodiversity informatics.
http://taxonworks.org
MIT License
87 stars 26 forks source link

Browse Nomenclature/OTU: strange display of synonyms combined with genus of parent species #1722

Closed typophyllum closed 3 years ago

typophyllum commented 4 years ago

This is apparently a known issue, but I cannot find it here (therefore I post it here to close a corresponding issue over there, related to import of OSF data, https://gitlab.com/SpeciesFileGroup/onedb2tw/-/issues/49).

Example:

grafik

grafik

Mesaphyllum peruvianum was cited once more as valid species of that genus, and then has been syonymized below Hyperphrona punctulata. The TW combination "Hyperphrona peruvianum" was never published and the gender-specific suffix is wrong.

This is still very confusing to me and I think it requires a better solution. Synonyms of species names are usually mentioned as original protonym or subsequently published combinations, but never with an artificial database combination.

proceps commented 4 years ago

This is a TW convention. If the species enter into synonymy and the genus of the valid species is different, according to ICZN, this species is transferred to the same genus as valid species. Even if this combination never published. If you look at the list of citation. The citation is not listed there. The title of the page is just a placeholder. This name is not completely useless. Although the synonym is invalid now, it is an available name which is now classified in a different genus, together with the valid name of this taxon. It still competes for secondary homonymy, with all other names included in the same genus.

typophyllum commented 4 years ago

If the name is just a placeholder, I still think that there must be a better solution to display this. Concerning OSF, for me we cannot display unpublished names in a taxonomic database. People will certainly get confused. And may then even publish them. And if the display in TW will be changed, it will become uncertain where they originated.

As for the competition for secondary homonymy: I cannot find a corresponding article of the Code. Article 53.3 (Homonyms in the species group) says, for secondary homonyms, that they need to be subsequently published in combination with the same generic name. For example, a paper that synonymizes Urubamba urux Liebermann 1951 under Jivarus americanus Giglio-Tos 1898 does not mention the fictitious combination "Jivarus urux", i.e. this combination isn't published. And, would Jivarus urux Giglio-Tos 1898, as valid species, really need a substitute name?

I think this issue should remain open, but I'm unable to reopen it.

proceps commented 4 years ago

ICZN does not have any requirement to publish new combination. This is not nomenclature, this is classification. Imagine situation, I am sure those exist in OSF too. Somebody make two genera synonys, each genus is has 5 species, but publication does not mentioned any new combination. In the botanical code, it is required that all new combination be explicit. In zoology, we can just move all species from one genus to another in the database. And this is is a legitimate procedure in the ICZN. Public should not see any of those names. I believe in TW we should only display the names where the name of a valid taxon is in the title. All synonymy will be listed under the valid name in the proper format.

proceps commented 4 years ago

Jivarus urux Giglio-Tos 1898 does not need a substitute name not because the combination was not published, but because it is an older homonym. If it is published after Urubamba urux Liebermann 1951, yes, it would need a substitute name.

typophyllum commented 4 years ago

Thank you. Jivarus urux Giglio-Tos 1898 was a bad example. Assuming there was a Jivarus urux Cigliano 2005, as I understand the Code, that name would remain valid, as long as nobody published the combination "Jivarus urux Liebermann 1951". (David incorporated the Code exceedingly thoroughly into SFS, and it alerts you when you add a homonym species name under a genus, but it doesn't alert when you synonymize a species name under a different genus that already includes the same species name,)

Apart from that, I think in a taxonomic database like OSF all nominal species should be displayed separately, to view their own taxonomic history (protonym, subsequent combinations, status changes, synonymizations, etc.) without mixup with other names. And it should by no means display unpublished combinations (currently with incorrect gender suffixes). No taxonomic work does that.

proceps commented 4 years ago

In the last example, a replacement name is required if the name with the same epithet are classified in the same genus. If a species is placed into synonymy with another species in different genus, it is transferred into that last genus. No combination is required. The name became invalid but it is still an available names. It still competes for the homonymy. Even if the combination is not published. ICZN does not have any requirements that combinations have to be published. The code does not have any requirements that synonymy have to be published. Those two acts are not nomenclatural changes. Those are related to the classification of the taxa. TaxonWorks has preserved all validations which were originally present in the SpeciesFile and have several classes of validation, which were not checked in SF.

LocoDelAssembly commented 4 years ago

Sorry to come back to this, but confusion happened once more regarding this convention. The example is Xiphidium (Xiphidium) geniculare Redtenbacher, 1891 which Sandcastle lists it as Conocephalus (Anisoptera) semivittatus geniculare (Redtenbacher, 1891). Furthermore, type information in OSF shows the name originally published, whereas Sandcastle shows the unpublished combination. I'm guessing here it is because how it is displayed and not a data issue, and if so, is this OK? How do I know the original combination of the typification?

Was not able to check CoLDP output because it has some issues at the moment. But also wondering how all this data should be exported in DwC and CoLDP?

Since Sandcastle IDs are not super stable screenshots below for posterity: image

Also browse specimen: image (TaxonDetermination not sure if import error or still display convention, but essentially cannot know label actually has Xiphidium (Xiphidium) geniculare written down)

Show type material: image

NOTE

Ignore URL identifiers, are placed there for debugging purposes and they won't be there in the future.

On behalf of @MMCigliano, CC @typophyllum

proceps commented 4 years ago

Type material should always show the original name of taxon (not current name of taxon). I believe this display should be corrected.

proceps commented 4 years ago

in OSF 'geniculare' is currently classified as a synonym of Conocephalus (Anisoptera) semivittatus vittatus. So its current rank is the same as the rank of valid taxon - subspecies. Its parent is the same as the parent of valid taxon - Conocephalus (Anisoptera) semivittatus. The current name of the taxon is correct.

typophyllum commented 4 years ago

This seems to be a result of the weird display of synonyms. Gomphocerus simillimus (never cited in the rank of subspecies) is a synonym of Aeropedellus variegatus variegatus (protonym Gomphocerus variegatus, the two most recent citations which confirm this are missing, since the import algorithm fails to resolve trinomial subspecies names). It doesn't make any sense to call this synonym Aeropedellus [SPECIES NOT SPECIFIED] simillimus instead of simply displaying the protonym Gomphocerus simillimus.

grafik

typophyllum commented 3 years ago

Looking at OSF data in TW, MMCigliano and I keep getting confused by the synonym names appearing in unknown combinations. I think there needs to be at least an option to customize Browse OTUs so that the original combination/protonym is shown, as is standard in practically all taxonomic publications.

The Code, in the context of homonymy, speaks explicitly of published combinations:

53.3. Homonyms in the species group Two or more available species-group names having the same spelling are homonyms [...] when they are subsequently published in combination with the same generic name (secondary homonymy)

57.3. Secondary homonyms 57.3.1. Identical species-group names established for different nominal taxa and subsequently brought together in combination with the same generic name are secondary homonyms [Art. 53.3] and the junior is invalid

mjy commented 3 years ago

I'm not sure if this is a data migration issue, likely not, but, in the short term:

typophyllum commented 3 years ago

It's not a migration issue but a strange peculiarity of TW. And I want to be able to view each synonym with its corresponding citations separately.

mjy commented 3 years ago

@proceps Should we just display original combination for yellow names?

proceps commented 3 years ago

It is just title, we can display original combination in the titles. But the taxa will still be listed under the valid genus name in the classification and few other places. And that cannot be changed. Than we will have an issues with OTUs attached to the synonyms. Which name you want to see in association whith the OTU? Current or original? I think, the best would be to modify the tytle to something like this: "Taxon1 (original combinaition) synonym (combination, etc) of Taxon2 (current combination)". That should definitely eliminate confusion.

mjy commented 3 years ago

Very good point @proceps, i.e. we need to emphasize this is a taxon (biological) page, that happens to contain nomenclature.

mjy commented 3 years ago

What about: OTU Aus bus Smith, 1920 currently OTU Bus bus" ?

proceps commented 3 years ago

OTU "Aus bus Smith, 1920 currently OTU Bus bus (Smith, 1920)" Add the author string, and do not include OTU in the name. This should be full name for any OTU.

mjy commented 3 years ago

Do you mean this?

"Aus bus Smith, 1920 currently Bus bus (Smith, 1920)

proceps commented 3 years ago

Yes

proceps commented 3 years ago

This should also work even for valid names, which has original combination different from current.

mjy commented 3 years ago

Was thinking that valid names would just be presented as is? Do we need the original? If we argue for original in that case we need 2x the original (invalid and valid could be different)

proceps commented 3 years ago

We will have two different OTUs if besides a protonym thereis a subsequent combination in the DB. Than you will have two forms. We already discussed it. The OTU should always be linked to the original combination of the protonym. This will resolve all the confusions.

proceps commented 3 years ago

Distribution, for example, could be attached to the subsequent combination, you will get a citation of the exact name use. And all distribution records for synonyms and combinations could be summarized to the valid name on the OTU page

mjy commented 3 years ago

I'm not sure I understand. OTUs can be linked to any name, that will not change. If you mean that:

1) In the label for the OTU 2) The original combination should be present when the name is not valid or current

Then I agree.

proceps commented 3 years ago

github.com/SpeciesFileGroup/taxonworks_doc/blob/master/manuals/OTU_BEST_PRACTICES.md

proceps commented 3 years ago

First portion of the OTU name will not change (original combination). The second half always changes to match the current taxonomic position.

mjy commented 3 years ago

Let's please add all possible combinations of data and their proposed corresponding label renderings in taxon (biological) pages here (if they happen to work for general OTU labels we can expand the use, let's keep focused for one use case).

https://docs.google.com/spreadsheets/d/19RIWCvq9zo1hu47nR99nF8X6_8NwO08eUPWrfMaLkjg/edit?usp=sharing

Please do not alter labels but rather provide alternates.

mjy commented 3 years ago

I know we have the theory worked out, this is a coding issue- providing exact strings and their corresponding labels (for all possibilities, regardless of best practices) will faciliate @jlpereira actually executing this. I've updated spreadsheet column headers to better reflect the possible considerations.

MMCigliano commented 3 years ago

Should we just display original combination for yellow names?

Yes, please. We prefer to see the original combination for synonyms, without any other automatically created combination.

proceps commented 3 years ago

@MMCigliano, Unfortunately this would not satisfy my need and needs of some other people. It will be confusing, if I know that I expect to see the synonym species in a particular genus, but instead I will see it with very old historical combination, which does not even have any sense now.

typophyllum commented 3 years ago

Perhaps the name could be removed from the hierarchy at the top of the page. Then it would be obvious that 1) the name is a synonym and 2) it is under a valid species. MM and I find the artificial combinations totally confusing.

mjy commented 3 years ago

Let's please keep this specific. I'm closing this issue and opening two others. 1) Browse OTU label; 2) Browse nomenclature label. The two are not the same. I will re-summarize on the open issues.

proceps commented 3 years ago

@typophyllum please follow the link for proposed changes.

https://docs.google.com/spreadsheets/d/19RIWCvq9zo1hu47nR99nF8X6_8NwO08eUPWrfMaLkjg/edit?usp=sharing