search

SpeciesFileGroup / taxonworks

Workbench for biodiversity informatics.
http://taxonworks.org
MIT License
87 stars 26 forks source link

Model - TaxonName - Procaryote names have broken rank validation #2128

Closed mjy closed 1 year ago

mjy commented 3 years ago

When I have a genus ranked name, and I try to assign it to a family parent, then I get an error message. See screenshot.

Screen Shot 2021-03-14 at 10 17 10 PM

proceps commented 3 years ago

I cannot replicate. Are you sure that both genus and family are covered by the same nomenclatural code?

mjy commented 3 years ago

Aha. Checking, nice idea.

mjy commented 3 years ago

@proceps I think this is still a problem. Edit: maybe a different problem.

Screen Shot 2021-04-20 at 11 23 51 PM

See argument in part here: https://pubmed.ncbi.nlm.nih.gov/29936290/

The names below this have ICN endings.

mjy commented 3 years ago

@jlpereira @proceps the original issue here is indeed due to incompatible codes, however they can't be changed, in the current UI.

To replicate:

We have two options: 1) we update the UI to let users switch codes, but only for names attached to root 2) we try to auto-switch the code when the name moves, this is likely more painful and I'm not sure I want to try and match ranks.

Thoughts?

proceps commented 3 years ago

ICN is very restrictive for name ending for all ranks, that is why you have those error messages. Amoebozoa is a zoological name, if you want to put the group under ICN, the Myxomycetes as a ICN Class would make a good name. The cited paper actually proposes only to transfer Myxomycetes (not all Amoebozoa) under ICN.

If you switch code for a taxon under the Root, you have to switch the ranks for all children. and yes, you will need to match the ranks, which could be relatively easy for common ranks. But you should also remember the family group names, which have different endings under different codes, and all higher ranks are also regulated under ICN.

Switching the Code is not the only issue with the current model. If you create a Family or Order name and decide to change its rank to the Genus, you cannot. The rank change is allow only within one rank group, so you can change the rank from genus to subgenus, but not from family to genus. I think those restrictions are quite useful.

proceps commented 3 years ago

should we close this?

mjy commented 3 years ago

No, I think the problem still exists.

proceps commented 1 year ago

duplicate of a recently closed issue