SpeciesFileGroup / taxonworks

Workbench for biodiversity informatics.
http://taxonworks.org
Other
84 stars 25 forks source link

[Bug]: Mystery of Origin for "Pupa" value in Biocuration for a Collection Object #2948

Closed debpaul closed 2 years ago

debpaul commented 2 years ago

Steps to reproduce the bug

Scenario: @tmcelrath and I curating INHS ENT records on Production with biocuration issues (e.g. female,male in dwc:sex on export).

1.Editing the Biocuration data for INHS Insect Collection 139107
2.Noted the record said "Pupa"
3.After we did the biocuration, we now see Pupa and Pupae
4.But @tmcelrath notes **we need to know where Pupa comes from** (and delete it?) We couldn't figure out its origin. He can provide more information if needed.

See "Pupa" in the history https://sfg.taxonworks.org/tasks/collection_objects/browse?collection_object_id=334042 -- note the export is now correct for this object
See both "Pupa" and "Pupae" in history https://sfg.taxonworks.org/tasks/collection_objects/browse?collection_object_id=1339146 -- note the export is now correct for this object.

Screenshot

image

Expected behavior

I'm not sure this is a bug? Maybe it was a value from some data import? The question is where did it come from?

Additional Screenshots

No response

Environment

Production

Sandbox Used

No response

Version

v0.24.2

Browser Used

firefox

mjy commented 2 years ago

Pupa is almost certainly not added to the biocuration group that is used to display choices in Comprehensive. Check to see that the group includes Pupa.

proceps commented 2 years ago

There are two biocuration classes in the DB: Pupa: https://sfg.taxonworks.org/controlled_vocabulary_terms/518 (comming from the original migration, with thousands of associated records) Pupae: https://sfg.taxonworks.org/controlled_vocabulary_terms/178 (created by Michele, with about a hundred of associated records).

proceps commented 2 years ago

please reload the page https://sfg.taxonworks.org/tasks/accessions/comprehensive?collection_object_id=1339146 You can see that both Pupa and Pupae are selected for the record. One of the biocuration classes was made invisible. Most likely, you would like to find all specimen records for Pupae, and manually reassigne those to Pupa. After that, you can delete one of the biocuration classes. And rename the other of if needed.

debpaul commented 2 years ago

@tmcelrath please note the above comments.

debpaul commented 2 years ago

Pupa is almost certainly not added to the biocuration group that is used to display choices in Comprehensive. Check to see that the group includes Pupa.

@mjy I see this in Manage Biocuration image

proceps commented 2 years ago

I added it when experimented with related records.

tmcelrath commented 2 years ago

I have updated the terms to make it so that "Pupa(e)" is the "Correct" term. I will do like Dmitry suggested and remove all Pupae [Deprecated] Biocurations and transition to "Pupa(e)".

tmcelrath commented 2 years ago

Pupae [Deprecated] has been deleted. Issue can be closed, mystery solved.