[Bug]: Saving a CO in Comprehensive takes much longer if many COs are assigned to collecting event

SpeciesFileGroup / taxonworks

Workbench for biodiversity informatics.

http://taxonworks.org

MIT License

87 stars 26 forks source link

[Bug]: Saving a CO in Comprehensive takes much longer if many COs are assigned to collecting event #3388

Open tmcelrath opened 1 year ago

tmcelrath commented 1 year ago

Steps to reproduce the bug

1. When I am in comprehensive and I assign a CO to a CE that has many other COs
2. And the CE is NOT being updated
3. Then saving takes much longer (>2 seconds, seems to scale linearly for number of assigned COs to given CE)
...

Screenshot

No response

Expected behavior

Should only update CE for all COs if the CE is modified within Comprehensive

Additional Screenshots

No response

Environment

Production

Sandbox Used

No response

Version

v0.32.2

Browser Used

Chrome

tmcelrath commented 1 year ago

Example in INHS Insect Collection: https://sfg.taxonworks.org/tasks/accessions/comprehensive?collection_object_id=1253264

mjy commented 1 year ago

Issue is blind cascading update of DwC when CE is saved (even with no changes).

[ ] Put a delayed job on for records of a ceratain size
[ ] Don't trigger if CE doesn't change.

mjy commented 1 month ago

@tmcelrath This should be resolved with Delayed jobs?

tmcelrath commented 1 month ago

No. Still an issue. Actually still an issue even if CE is not modified at all. Eg I can modify a CO buffered field and save and it takes longer if it’s a CE with lots of COs on it.