SpeciesFileGroup / taxonworks

Workbench for biodiversity informatics.
http://taxonworks.org
Other
87 stars 26 forks source link

[Bug]: Hotkey not working in CSD #3999

Closed mmkohler closed 1 month ago

mmkohler commented 3 months ago

Steps to reproduce the bug

In CSD the Save hotkey is not working. I am using Chrome, I am on a PC. When I hit Alt S in CSD, nothing hapens. I am able to save my work by clicking the save button, but the hotkey does not work.

Screenshot

No response

Expected behavior

When I hit alt S on a PC, I expect it to save.

Additional Screenshots

No response

Environment

Production

Sandbox Used

No response

Version

No response

Browser Used

Chrome

jlpereira commented 3 months ago

Hello @mmkohler

I can't replicate this. Shortcuts are:

MacOS: Ctrl + S Windows/Linux: Alt + S

I tested this on Windows/Chrome and it works for me, can you provide a link to try it? Did you try it in incognito mode? You may have an extension that is interfering with the shortcuts working.

mmkohler commented 3 months ago

When I load CSD to put in new specimens I still have this issue. When I load the CSD from the filter, I did not have the issue.

From: José Luis Pereira @.> Sent: Friday, August 2, 2024 2:06 PM To: SpeciesFileGroup/taxonworks @.> Cc: Kohler, Michelle Marie @.>; Mention @.> Subject: Re: [SpeciesFileGroup/taxonworks] [Bug]: Hotkey not working in CSD (Issue #3999)

Hello @mmkohlerhttps://urldefense.com/v3/__https:/github.com/mmkohler__;!!DZ3fjg!5KLLVNXcZkKmCyNOGHqnSk-xU8ok0dXc8euE4cF3FrAl-JyBqp3r1alQ2pEicJprxJbKjKZU5FTzQTt1HQ_QkZqgtWo$

I can't replicate this. Shortcuts are:

MacOS: Ctrl + S Windows/Linux: Alt + S

I tested this on Windows/Chrome and it works for me, can you provide a link to try it? Did you try it in incognito mode? You may have an extension that is interfering with the shortcuts working.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/SpeciesFileGroup/taxonworks/issues/3999*issuecomment-2265978093__;Iw!!DZ3fjg!5KLLVNXcZkKmCyNOGHqnSk-xU8ok0dXc8euE4cF3FrAl-JyBqp3r1alQ2pEicJprxJbKjKZU5FTzQTt1HQ_QuPkXDdI$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AGCPMOHE5NMS6AEOBNFZH7LZPPKBTAVCNFSM6AAAAABL42ZDRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVHE3TQMBZGM__;!!DZ3fjg!5KLLVNXcZkKmCyNOGHqnSk-xU8ok0dXc8euE4cF3FrAl-JyBqp3r1alQ2pEicJprxJbKjKZU5FTzQTt1HQ_QEzsLifA$. You are receiving this because you were mentioned.Message ID: @.**@.>>

jlpereira commented 3 months ago

I still can't replicate it @mmkohler Can you try on another computer to make sure the problem is not related to your computer?

tmcelrath commented 2 months ago

I have this issue too. It popped up after the update to 0.43.0. At first, it works, but then after working in CSD for awhile (not sure the exact trigger), all hotkeys stop working.

tmcelrath commented 2 months ago

When I refresh, hotkeys are working again.

tmcelrath commented 2 months ago

For me, after working in the task (editing/saving), suddenly the "control" key starts opening the collecting event in a new window when pressing control by itself. That may be related. I'm in Firefox.

jlpereira commented 2 months ago

I'm going to need more specific steps to replicate this, and if you have the exact link where you're trigger this it would be great.

But the most important are all the steps you're doing to trigger this issue, each click you make, everything you're opening(Including radials)

jlpereira commented 2 months ago

For me, after working in the task (editing/saving), suddenly the "control" key starts opening the collecting event in a new window when pressing control by itself. That may be related. I'm in Firefox.

I see what happens in this case, hotkey manager event can't remove pressed keys from the stack because it's focus a new window. I will change this shortcut to open in the same window